Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FRQ: extend functionality of frame.data() to accept lists #35

Closed
3 tasks done
kay-ro opened this issue Jun 3, 2024 · 0 comments · Fixed by #70
Closed
3 tasks done

FRQ: extend functionality of frame.data() to accept lists #35

kay-ro opened this issue Jun 3, 2024 · 0 comments · Fixed by #70
Assignees
Labels
module: base new feature New feature release: minor Issues that need to be addressed in a minor release status: ready for review Needs to be reviewed

Comments

@kay-ro
Copy link
Member

kay-ro commented Jun 3, 2024

Proposed new feature or change:

The Frame s of Trajectory objects store all data and specific values can be extracted with frame.data() by supplying the wanted keys as arguments. But often it is easier to supply a list or array of keys which is not possible at the moment, therefore it would help to add a recursive call at the beginning of the function to accept lists as well as arguments.

if isinstance(args, (list, np.ndarray)):
    return data(self, *args, ptype = ptype, zerofill = zerofill, return_keys = return_keys)
  • implement and check implementation
  • update documentation
  • add example
@kay-ro kay-ro added new feature New feature release: minor Issues that need to be addressed in a minor release module: base labels Jun 3, 2024
@hechtprojects hechtprojects added this to the release v1.1.0 milestone Jun 4, 2024
@hechtprojects hechtprojects added the status: to do Issues that someone needs to work on label Jun 4, 2024
@kay-ro kay-ro self-assigned this Oct 18, 2024
kay-ro pushed a commit that referenced this issue Oct 18, 2024
@kay-ro kay-ro added status: ready for review Needs to be reviewed and removed status: to do Issues that someone needs to work on labels Oct 21, 2024
@kay-ro kay-ro linked a pull request Oct 21, 2024 that will close this issue
@kay-ro kay-ro closed this as completed Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: base new feature New feature release: minor Issues that need to be addressed in a minor release status: ready for review Needs to be reviewed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants