Skip to content

Commit

Permalink
fix: Removing image build/push job in integration tests
Browse files Browse the repository at this point in the history
Closes: #60
  • Loading branch information
tazarov committed Aug 22, 2024
1 parent cfca0fb commit f8662da
Showing 1 changed file with 60 additions and 56 deletions.
116 changes: 60 additions & 56 deletions .github/workflows/integration-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,61 +22,61 @@ env:
IMAGE_NAME: "ghcr.io/amikos-tech/chromadb-chart/chroma"
LATEST_VERSION: "0.5.5"
jobs:
build-images:
strategy:
matrix:
chroma-version:
[
0.4.9,
0.4.10, #pre-flight checks introduced
0.4.16, #multi-tenancy introduced
0.4.24,
0.5.5,
]
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v2
with:
fetch-depth: 0
- name: Log in to the Container registry
uses: docker/[email protected]
with:
registry: ${{ env.REGISTRY }}
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}
- name: Docker meta
id: meta
uses: docker/metadata-action@v4
with:
images: ${{ env.IMAGE_NAME }}
- name: Set up QEMU
uses: docker/setup-qemu-action@v2
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v2
- name: Build and push release Docker image
uses: docker/[email protected]
if: ${{ env.LATEST_VERSION == matrix.chroma-version }}
with:
context: .
file: image/Dockerfile
push: true
platforms: linux/amd64,linux/arm64
build-args: |
CHROMA_VERSION=${{ matrix.chroma-version }}
tags: "${{ env.IMAGE_NAME }}:${{ matrix.chroma-version }}-dev,${{ env.IMAGE_NAME }}:canary"
- name: Build and push release Docker image
uses: docker/[email protected]
if: ${{ env.LATEST_VERSION != matrix.chroma-version }}
with:
context: .
file: image/Dockerfile
push: true
platforms: linux/amd64,linux/arm64
labels: ${{ steps.meta.outputs.labels }}
build-args: |
CHROMA_VERSION=${{ matrix.chroma-version }}
tags: "${{ env.IMAGE_NAME }}:${{ matrix.chroma-version }}-dev"
# build-images:
# strategy:
# matrix:
# chroma-version:
# [
# 0.4.9,
# 0.4.10, #pre-flight checks introduced
# 0.4.16, #multi-tenancy introduced
# 0.4.24,
# 0.5.5,
# ]
# runs-on: ubuntu-latest
# steps:
# - name: Checkout
# uses: actions/checkout@v2
# with:
# fetch-depth: 0
# - name: Log in to the Container registry
# uses: docker/[email protected]
# with:
# registry: ${{ env.REGISTRY }}
# username: ${{ github.actor }}
# password: ${{ secrets.GITHUB_TOKEN }}
# - name: Docker meta
# id: meta
# uses: docker/metadata-action@v4
# with:
# images: ${{ env.IMAGE_NAME }}
# - name: Set up QEMU
# uses: docker/setup-qemu-action@v2
# - name: Set up Docker Buildx
# uses: docker/setup-buildx-action@v2
# - name: Build and push release Docker image
# uses: docker/[email protected]
# if: ${{ env.LATEST_VERSION == matrix.chroma-version }}
# with:
# context: .
# file: image/Dockerfile
# push: true
# platforms: linux/amd64,linux/arm64
# build-args: |
# CHROMA_VERSION=${{ matrix.chroma-version }}
# tags: "${{ env.IMAGE_NAME }}:${{ matrix.chroma-version }}-dev,${{ env.IMAGE_NAME }}:canary"
# - name: Build and push release Docker image
# uses: docker/[email protected]
# if: ${{ env.LATEST_VERSION != matrix.chroma-version }}
# with:
# context: .
# file: image/Dockerfile
# push: true
# platforms: linux/amd64,linux/arm64
# labels: ${{ steps.meta.outputs.labels }}
# build-args: |
# CHROMA_VERSION=${{ matrix.chroma-version }}
# tags: "${{ env.IMAGE_NAME }}:${{ matrix.chroma-version }}-dev"
integration-test:
needs: build-images
strategy:
Expand Down Expand Up @@ -107,13 +107,17 @@ jobs:
uses: medyagh/setup-minikube@latest
with:
kubernetes-version: ${{ matrix.kubernetes-version }}
- name: Build image from Dockerfile
run: |
eval $(minikube docker-env)
docker build -t ghcr.io/amikos-tech/chromadb-chart/chroma:${{ matrix.chroma-version }} --build-arg CHROMA_VERSION=${{ matrix.chroma-version }} -f image/Dockerfile .
- name: Install chromadb
run: |
set -e
sleep 20
helm install chromadb ./charts/chromadb-chart --set chromadb.isPersistent=true \
--set chromadb.allowReset=true \
--set chromadb.apiVersion=${{ matrix.chroma-version }}-dev
--set chromadb.apiVersion=${{ matrix.chroma-version }}
- name: Wait for deployment to be ready
run: |
kubectl wait \
Expand Down

0 comments on commit f8662da

Please sign in to comment.