-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement proposed batch size to be floor(B/N) #36
Comments
We're already doing a version of this in the |
I'd maybe use |
This issue was moved to initc3/HoneyBadgerBFT-Python#28 \cc @afck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@amiller I assume you are well aware of this as there's already a
TODO
note in the code about implementing the random selection.Nevertheless, regardless of the size, only one element (
tx_to_send[0]
) is currently passed to_run_round()
:So
_run_round()
andtpke.encrypt()
should be capable to take alist
or a similar data structure.tpke.encrypt()
would need to be modified so that a string (e.g.:cPickle.dumps(raw)
) is passed to the padding operation.So this issue could be done in two (or three) parts:
_run_round()
, e.g.:tx_to_send[:1]
floor(B/N)
transactions to_run_round()
, e.g.:tx_to_send[:int(B/N)]
The text was updated successfully, but these errors were encountered: