Dynamic fields

[cuamckuu]

Hi, is there a way to add dynamic column?

I tried adding property, but it's not working

class Test(sqlmodel.SQLModel, table=True):
    id: Optional[int] = sqlmodel.Field(default=None, primary_key=True)
    name: str

    @property
    def random() -> float:
        return random.random()

class TestAdmin(ModelAdmin, model=Test):
    column_list = [
        Test.id,
        Test.name,
        Test.random,
    ]

admin.register_model(TestAdmin)

Exception is

Traceback (most recent call last):
  File "D:\soft\Python\Python39\lib\runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "D:\soft\Python\Python39\lib\runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "c:\Users\Alex\.vscode\extensions\ms-python.python-2022.8.0\pythonFiles\lib\python\debugpy\__main__.py", line 45, in <module>
    cli.main()
  File "c:\Users\Alex\.vscode\extensions\ms-python.python-2022.8.0\pythonFiles\lib\python\debugpy/..\debugpy\server\cli.py", line 444, in main    
    run()
  File "c:\Users\Alex\.vscode\extensions\ms-python.python-2022.8.0\pythonFiles\lib\python\debugpy/..\debugpy\server\cli.py", line 285, in run_file
    runpy.run_path(target_as_str, run_name=compat.force_str("__main__"))
  File "D:\soft\Python\Python39\lib\runpy.py", line 268, in run_path
    return _run_module_code(code, init_globals, run_name,
  File "D:\soft\Python\Python39\lib\runpy.py", line 97, in _run_module_code
    _run_code(code, mod_globals, init_globals,
  File "D:\soft\Python\Python39\lib\runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File ".\main.py", line 40, in <module>
    admin.register_model(TestAdmin)
  File ".\venv\lib\site-packages\sqladmin\application.py", line 104, in register_model
    self._model_admins.append((model()))
  File ".\venv\lib\site-packages\sqladmin\models.py", line 527, in __init__
    self._list_attrs = self.get_list_columns()
  File ".\venv\lib\site-packages\sqladmin\models.py", line 821, in get_list_columns
    return self._build_column_list(
  File ".\venv\lib\site-packages\sqladmin\models.py", line 805, in _build_column_list
    attrs = [self.get_model_attr(attr) for attr in include]
  File ".\venv\lib\site-packages\sqladmin\models.py", line 805, in <listcomp>
    attrs = [self.get_model_attr(attr) for attr in include]
  File ".\venv\lib\site-packages\sqladmin\models.py", line 772, in get_model_attr
    assert isinstance(attr, (str, InstrumentedAttribute))
AssertionError

[aminalaee]

Hey, what is the purpose of that dynamic property? Is it only for displaying calculated data?

[cuamckuu]

I want an easy way to display data from custom queries or external sources.

For example, for table like City I could fetch current weather or something like that, or maybe calculate salary for every Worker.

This feature will simplify dashboard creation, without need to create custom templates with javascript and non-obvious logic

[aminalaee]

it would make sense, feel free to create a PR for it.

[cuamckuu]

I found a hacky solution, which could easily break in later versions, but for my usecase it's ok for now

Here it is:

import sqlmodel

from sqladmin import ModelAdmin
from sqlalchemy import Column

from app.database import Test


class Test(sqlmodel.SQLModel, table=True):
    id: Optional[int] = sqlmodel.Field(default=None, primary_key=True)
    name: str

    @property
    def random(self) -> float:
        return random.random()


class DynamicColumn(Column):
    def __init__(self, name):
        super().__init__(key=name, name=name)


class TestAdmin(ModelAdmin, model=Test):
    column_list = [
        Test.id,
        Test.name,
        'random',
    ]

    column_labels = {'random': 'random'}
    _column_labels_value_by_key = {'random': DynamicColumn('random')}

[cuamckuu]

@aminalaee, I want to make PR to make it less hacky, what do you think about such design?

import sqlmodel

from sqladmin import ModelAdmin

from app.database import Test

class Test(sqlmodel.SQLModel, table=True):
    id: Optional[int] = sqlmodel.Field(default=None, primary_key=True)
    name: str

    @property
    def random(self) -> float:
        return random.random()

class TestAdmin(ModelAdmin, model=Test):
    column_list = [
        Test.id,
        Test.name,
        'random',
    ]
    dynamic_columns = ['random']