-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for filesize@10
#397
Comments
Update to ngx-filesize 3.0.0 doesn't work in my Angular 14 project. Having errors: There's no "filesize" dependency of ngx-filesize dependency in yarn.lock file (or package-lock.json) at my side. And I don't like having ngx-filesize v2 in my Angular 14 project, because it uses Angular's deprecated View Engine, not Ivy compiler. Kind regards, |
Hey @eXpertise7 ! Thanks for the feedback on 3.0.0! Did you notice we made a breaking change moving We no longer install Instead you have to install it: yarn add ngx-filesize filesize@9 (Since most package managers don't auto-install peerDeps by default) |
(This move was made because I wanted |
Summary
Starting with
[email protected]
we now support a predefined set offilesize
versions ->= 6.0.0 < 10.0.0
, this is due to10.0.0
requiring a{ filesize } from 'filesize'
import whereas previous versions requirefilesize from 'filesize'
.I could only thing of 2 ways for us to add support for
filesize@10
:^10.0.0
(or>= 10.0.0
?) with the named-import API, maybe in[email protected]
?import { NgxFilesizeModule } from 'ngx-filesize/filesize@10
opt-in export, effectively letting us supportfilesize@10
but with a secondary API entrypoint.The text was updated successfully, but these errors were encountered: