AMP-30334 add base 36 generator

amplitude · Oct 8, 2020 · 7e43157 · 7e43157
1 parent 825f34f
commit 7e43157
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 11 deletions.
diff --git a/src/main/java/com/amplitude/identitymanager/Identity.java b/src/main/java/com/amplitude/identitymanager/Identity.java
@@ -6,39 +6,35 @@ public class Identity {
     private String _userId;
     private String _deviceId;
 
-    private void logIdentityWarning(String message) {
-        Log.w(Identity.class.getName(), message);
-    }
-
     public String initializeDeviceId(String deviceId) {
-        if (deviceId == null) {
+        if (_deviceId == null) {
             String deviceIdToUse = "";
             if (deviceId.length() > 0) {
                 deviceIdToUse = deviceId;
             } else {
-                deviceIdToUse = "generateBase36Id";
+                deviceIdToUse = IdentityUtils.generateBase36Id();
             }
             _deviceId = deviceIdToUse;
         } else {
-            logIdentityWarning("Cannot set device ID twice for same identity. Skipping operation.");
+            IdentityUtils.logIdentityWarning("Cannot set device ID twice for same identity. Skipping operation.");
         }
 
         return deviceId;
     }
 
     public String initializeDeviceId() {
         if (_deviceId == null) {
-            _deviceId = "generateBase36Id";
+            _deviceId = IdentityUtils.generateBase36Id();
         } else {
-            logIdentityWarning("Cannot set device ID twice for same identity. Skipping operation.");
+            IdentityUtils.logIdentityWarning("Cannot set device ID twice for same identity. Skipping operation.");
         }
 
         return _deviceId;
     }
 
     public String getDeviceId() {
         if (_deviceId == null) {
-            logIdentityWarning("Did not detect device ID; generating one for this instance.");
+            IdentityUtils.logIdentityWarning("Did not detect device ID; generating one for this instance.");
             return initializeDeviceId();
         } else {
             return _deviceId;

diff --git a/src/main/java/com/amplitude/identitymanager/IdentityManager.java b/src/main/java/com/amplitude/identitymanager/IdentityManager.java
@@ -26,4 +26,4 @@ public Identity getInstance() {
             return identityToSet;
         }
     }
-}
+}
diff --git a/src/main/java/com/amplitude/identitymanager/IdentityUtils.java b/src/main/java/com/amplitude/identitymanager/IdentityUtils.java
@@ -0,0 +1,24 @@
+package com.amplitude.identitymanager;
+
+import android.util.Log;
+
+public class IdentityUtils {
+    static private final int device_id_length = 25;
+    static private final String base_36_char_set = "abcdefghijklmnopqrstuvwxyz0123456789";
+    static private final int base_36_radix = 36;
+
+    static void logIdentityWarning(String message) {
+        Log.w(Identity.class.getName(), message);
+    }
+
+    static String generateBase36Id() {
+        String stringBuilder = "";
+        for (int idx = 0; idx < device_id_length; idx++) {
+            double randomIdx = Math.floor(Math.random() * base_36_radix);
+            char nextChar = base_36_char_set.charAt((int)randomIdx);
+            stringBuilder += nextChar;
+        }
+
+        return stringBuilder;
+    }
+}
-Original file line number
+Diff line change
@@ Expand Up / @@ -26,4 +26,4 @@ public Identity getInstance() { @@
                 return identityToSet;
             }
         }
-    }
+    }