From 7fd9e816f4e62a4340ea64c8e5d758b70167e49f Mon Sep 17 00:00:00 2001 From: HJK51 <70740626+HJK51@users.noreply.github.com> Date: Wed, 17 Jul 2024 14:39:04 +0900 Subject: [PATCH 1/5] Update openadstream.js make url path for ads tag --- ads/vendors/openadstream.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/ads/vendors/openadstream.js b/ads/vendors/openadstream.js index 4ea84bb136b7..403aba672938 100644 --- a/ads/vendors/openadstream.js +++ b/ads/vendors/openadstream.js @@ -5,15 +5,15 @@ import {validateData, writeScript} from '#3p/3p'; * @param {!Object} data */ export function openadstream(global, data) { - validateData(data, ['adhost', 'sitepage', 'pos'], ['query']); + validateData(data, ['adhost','urlpath', 'sitepage', 'pos'], ['query']); let url = 'https://' + encodeURIComponent(data.adhost) + - '/3/' + + '/' + + data.urlpath + + '/' + data.sitepage + - '/1' + - String(Math.random()).substring(2, 11) + '@' + data.pos; From cd4a7e489896cc8bd0b1835e18d4c92c385666cf Mon Sep 17 00:00:00 2001 From: HJK51 <70740626+HJK51@users.noreply.github.com> Date: Wed, 17 Jul 2024 14:53:06 +0900 Subject: [PATCH 2/5] Update path for openadstream ads url add path for ads tag url --- ads/vendors/openadstream.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/ads/vendors/openadstream.md b/ads/vendors/openadstream.md index 8dd5e2e4464f..58d15896c061 100644 --- a/ads/vendors/openadstream.md +++ b/ads/vendors/openadstream.md @@ -10,6 +10,7 @@ height="250" type="openadstream" data-adhost="oasc-training7.247realmedia.com" + data-urlpath="/RealMedia/ads/ads_path" data-sitepage="dx_tag_pvt_site" data-pos="x04" data-query="keyword=keyvalue&key2=value2" @@ -25,6 +26,7 @@ height="90" type="openadstream" data-adhost="oasc-training7.247realmedia.com" + data-urlpath="/RealMedia/ads/ads_path" data-sitepage="dx_tag_pvt_site" data-pos="x50,x51!x50" > @@ -34,6 +36,7 @@ height="250" type="openadstream" data-adhost="oasc-training7.247realmedia.com" + data-urlpath="/RealMedia/ads/ads_path" data-sitepage="dx_tag_pvt_site" data-pos="x50,x51!x51" > @@ -47,6 +50,7 @@ For details on the configuration semantics, please contact the ad network or ref ### Required parameters - `adhost`: OAS cname. Must start with HTTPS. +- `urlpath`: path for ads tag. - `sitepage`: Sitepage configured for this ad spot. - `pos`: Position for the this ad spot. From abd020512897c2d797e3f19e728ec07252b51f01 Mon Sep 17 00:00:00 2001 From: HJK51 <70740626+HJK51@users.noreply.github.com> Date: Thu, 18 Jul 2024 13:03:08 +0900 Subject: [PATCH 3/5] prettier check --- ads/vendors/openadstream.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ads/vendors/openadstream.js b/ads/vendors/openadstream.js index 403aba672938..064bfe0e3bd4 100644 --- a/ads/vendors/openadstream.js +++ b/ads/vendors/openadstream.js @@ -5,7 +5,7 @@ import {validateData, writeScript} from '#3p/3p'; * @param {!Object} data */ export function openadstream(global, data) { - validateData(data, ['adhost','urlpath', 'sitepage', 'pos'], ['query']); + validateData(data, ['adhost', 'urlpath', 'sitepage', 'pos'], ['query']); let url = 'https://' + From 39bcd251a74e27b22dc3cd4a2898c3e799f96c5c Mon Sep 17 00:00:00 2001 From: HJK51 <70740626+HJK51@users.noreply.github.com> Date: Thu, 18 Jul 2024 13:37:15 +0900 Subject: [PATCH 4/5] Prettier check --- ads/vendors/openadstream.js | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/ads/vendors/openadstream.js b/ads/vendors/openadstream.js index 064bfe0e3bd4..aa721eb8c191 100644 --- a/ads/vendors/openadstream.js +++ b/ads/vendors/openadstream.js @@ -1,24 +1,24 @@ -import {validateData, writeScript} from '#3p/3p'; +import { validateData, writeScript } from "#3p/3p"; /** * @param {!Window} global * @param {!Object} data */ export function openadstream(global, data) { - validateData(data, ['adhost', 'urlpath', 'sitepage', 'pos'], ['query']); + validateData(data, ["adhost", "urlpath", "sitepage", "pos"], ["query"]); let url = - 'https://' + + "https://" + encodeURIComponent(data.adhost) + - '/' + + "/" + data.urlpath + - '/' + + "/" + data.sitepage + - '@' + + "@" + data.pos; if (data.query) { - url = url + '?' + data.query; + url = url + "?" + data.query; } writeScript(global, url); } From 4b5db06f6f963c2975c1fd85c4f4611f54f9c0c5 Mon Sep 17 00:00:00 2001 From: HJK51 <70740626+HJK51@users.noreply.github.com> Date: Thu, 18 Jul 2024 13:58:37 +0900 Subject: [PATCH 5/5] Prettier test --- ads/vendors/openadstream.js | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/ads/vendors/openadstream.js b/ads/vendors/openadstream.js index aa721eb8c191..cbfc34f52aa8 100644 --- a/ads/vendors/openadstream.js +++ b/ads/vendors/openadstream.js @@ -1,24 +1,24 @@ -import { validateData, writeScript } from "#3p/3p"; +import {validateData, writeScript } from '#3p/3p'; /** * @param {!Window} global * @param {!Object} data */ export function openadstream(global, data) { - validateData(data, ["adhost", "urlpath", "sitepage", "pos"], ["query"]); + validateData(data, ['adhost', 'urlpath', 'sitepage', 'pos'], ['query']); let url = - "https://" + + 'https://' + encodeURIComponent(data.adhost) + - "/" + + '/' + data.urlpath + - "/" + + '/' + data.sitepage + - "@" + + '@' + data.pos; if (data.query) { - url = url + "?" + data.query; + url = url + '?' + data.query; } writeScript(global, url); }