Move version detection offset of Honkers from 4000 to 2000 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version data of Honkers 2.7.0 lies at 0x08FB, which is 2299 in decimal, way smaller than 4000. This patch sets the detection offset to 2000 in decimal, allowing proper detection. Let's see if things break in 2.8.0 and onwards...
|
I have just test it on version 3.0 locally. Setting the offset to 3000 will lead to version check failure and seek("set", 2000) runs well. Thank you for your patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version data of Honkers 2.7.0 lies at 0x08FB, which is 2299 in decimal, way smaller than 4000. This patch sets the detection offset to 2000 in decimal, allowing proper detection. Let's see if things break in 2.8.0 and onwards...