Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slight Updates #3

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Slight Updates #3

wants to merge 3 commits into from

Conversation

simonhagger
Copy link

I have updated the Angular version to 18.2 in this pull request. I have also made some adjustments to the way in which AuthGuard is implemented:

  • Guard is refactored to newer Angular style
  • Default clerk.redirectToSignIn({afterSignInUrl: state.url}) has had the deprecated parameter replaced with clerk.redirectToSignIn({signInFallbackRedirectUrl: state.url,}) as suggested in docs
  • New Guard added for inverse path "ClerkNoAuthGuardService" to be able to prevent (for example) visiting a sign-in page, when you are already signed in.
  • Docs updated (was originally a typo in description of AuthGuard as the function was actually prefixed with "Clerk", have updated the Readme accordingly

…hild as well.

Inclusion of additional Guard for NoAuth case.
Changed naming in readme file to reflect correct names and additional case.
Also - replaced deprecated parameter in redirectToSignIn.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant