fix(PeriphDrivers, Other): Fix UART clock source selection #1304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated defined clock sources for ME30 UART - Moved clock source enablement from init function to clock source selection function. Signed-off-by: Furkan Akkiz <[email protected]>
This commit removes clock source selection feature from MXC_UART_SetFrequency function because there is MXC_UART_SetClockSource function for this operation. Signed-off-by: Furkan Akkiz <[email protected]>
This commit adds wrapper function of MXC_UART_SetClockSource function. Wrapper function converts Zephyr clock source values to mxc_uart_clock_t type. Signed-off-by: Furkan Akkiz <[email protected]>
hfakkiz
requested review from
ttmut,
MaureenHelm,
kevin-gillespie and
sihyung-maxim
github-actions
bot
added
MAX32690
hfakkiz
changed the title
ttmut
approved these changes
Dec 19, 2024
|
Please review it. it is required by Walleye's CI tests. It blocks Flash tests. |
gkhnclkmxm
approved these changes
Dec 19, 2024
sihyung-maxim
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
@kevin-gillespie @EricB-ADI so you're aware of these changes.
|
if everyone is ok, please merge it. Need to have it ASAP. https://github.com/adi-innersource/zephyr/actions/runs/12413252868 |
sihyung-maxim
pushed a commit
to analogdevicesinc/hal_adi
that referenced
this pull request
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR solves UART clock source selection problems for ME18 and ME30. Problems:
For ME18, "MXC_UART_SetFrequency" function changes clock source but it is not a good approach. There is "MXC_UART_SetClockSource" function and user should use this function to change clock source of UART.
Removed "MXC_UART_ERTCO_CLK" enum from ME30 files because it does not used by UART.
Fixed build error of ME30 caused by "MSDK_NO_GPIO_CLK_INIT" flag's line.
Moved clock source enablement into "MXC_UART_SetClockSource" function for ME30.
Also, this PR adds wrapper function of "MXC_UART_SetClockSource" to Zephyr "hal_adi" to enable clock source selection feature in Zephyr. It handles clock source index differences between MSDK and Zephyr.
Checklist Before Requesting Review