Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Short-Cut Alt+R in conflict with Eclipse-Main-Menu Run Short-Cut Alt+R #181

Closed
makkimesser opened this issue Dec 13, 2020 · 13 comments
Closed

Comments

@makkimesser
Copy link

The key-binding of Alt+R to EasyShell-Run is in conflict with the Eclipse-Main-Menu Run, that also has binding to Alt+R.

I know, I can unbind it in Preferences, Keys. But I have more that one Eclipse-Instance and have to do this for each again.
I would suggest to change the binding to a short-cut, that is not in conflict with the Eclipse-Main-Menu.

@anb0s
Copy link
Owner

anb0s commented Dec 14, 2020

Yes, see this issues also and it's annoying. Should be fixed for 2.2

@anb0s
Copy link
Owner

anb0s commented Jan 3, 2021

I will change it to "Alt+Shift+R" - any objections?

anb0s added a commit that referenced this issue Jan 3, 2021
#181

Changed default key binding of "EasyShell Run" from "Alt+R" to
"Alt+Shift+R" to avoid conflicts.

Signed-off-by: Andre Bossert <[email protected]>
@makkimesser
Copy link
Author

makkimesser commented Jan 6, 2021

In some Editors (e.g. Java-, Lua-Editor) Alt+Shift+R is used for Refactor-Rename elements. What about to use Ctrl-Shift-R?

@anb0s
Copy link
Owner

anb0s commented Jan 8, 2021

"Ctrl+Shift+R" is used for "Open Ressource" and lot of other commands are using "Ctrl+Shift+" pattern already - this is why i've used "Alt+" for all commands and also ""Alt+Shift+E" for "Multi Selection".

Hm, i do not see conflict with "Alt+Shift+R" in Java-Editor etc. I'm using "Eclipse IDE for Java Developers" and also "Eclipse IDE for C/C++ Developers". What is your distribution or can you provide more information?

@makkimesser
Copy link
Author

Concerning Alt+Shift+R see https://www.vogella.com/tutorials/EclipseShortcuts/article.html under 7. Refactoring Section.

I use Eclipse JEE-Distribution "Eclipse IDE for Enterprise Java Developers" from https://www.eclipse.org/downloads/packages/release/2020-12/r/eclipse-ide-enterprise-java-developers

It is difficult to find a Short-Cuts that's meaningfull but unused :-(.
What about to add an Entry to the Main-Eclipse Run-Menu?

@makkimesser
Copy link
Author

I tested V2.2.0.v20210403 and I found that the binding Alt-Shift-R is now in conflict with the Java-Editor Refactor-Rename, see my comment above.

@anb0s
Copy link
Owner

anb0s commented Apr 7, 2021

Yes, i know :( I will check this "shortcuts" topic together with #175 until v2.2 final release and hope to find something that does not collide with most Eclipse distributions...

@anb0s
Copy link
Owner

anb0s commented May 16, 2021

"Alt + Shift + R" is just working in all my installations - i do not see any conflicting binding...

@makkimesser
Copy link
Author

Concerning Alt+Shift+R see https://www.vogella.com/tutorials/EclipseShortcuts/article.html under 7. Refactoring Section.

@anb0s
Copy link
Owner

anb0s commented May 17, 2021

Yes sure, but how can i trigger this? I've tried all the perspectives and this binding is just working for EasyShell Run and does not show the rename refactoring as expected. There is no shortcut shown in menu:
image

Anyway i will use another schema for all commands like "Alt + E" for EasyShell and then additional letter for sub command:
image

@makkimesser
Copy link
Author

Open JavaEditor, place Cursor on ClassName, then context-menu:
image

Open JavaEditor, place Cursor on ClassName, then main-menu refactoring:
image

@makkimesser
Copy link
Author

makkimesser commented May 17, 2021

The shortcuts with Alt+E, R seems a good decision and has minimal conflicts, that does not matter to me:
image

@anb0s anb0s closed this as completed in 892505c May 18, 2021
anb0s added a commit that referenced this issue May 18, 2021
@anb0s
Copy link
Owner

anb0s commented May 18, 2021

see Release v2.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants