Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add suggested fixed version #2271

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

add suggested fixed version #2271

wants to merge 16 commits into from
+77 −12

Conversation

tomersein
Copy link
Contributor

@tomersein tomersein commented Nov 20, 2024 •
edited
Loading

closes - #2264

this PR aims to add a new field to match details which specifies the suggested fixed version

@tomersein tomersein mentioned this pull request Nov 20, 2024
Open
@willmurphyscode
Copy link
Contributor

The discussion at #2264 (comment) should be wrapped up before we merge this.

@tomersein
sort fixed versions
75c1b96 
Signed-off-by: tomersein <[email protected]>
@tomersein tomersein changed the title Filter unrelated fixed version Sort fixed version according to the package version Dec 13, 2024
@tomersein
Copy link
Contributor Author

hi @willmurphyscode ,
fixed it from filtering to sorting (1st one is most relevant)

@tomersein
sort fixed versions
dac6726 
Signed-off-by: tomersein <[email protected]>
@tomersein
sort fixed versions
4ceadd6 
Signed-off-by: tomersein <[email protected]>
@tomersein
sort fixed versions
688fd41 
Signed-off-by: tomersein <[email protected]>
@tomersein
suggest fixed version
a331bce 
Signed-off-by: tomersein <[email protected]>
@tomersein
suggest fixed version
a58771b 
Signed-off-by: tomersein <[email protected]>
@tomersein
suggest fixed version
e1ef84f 
Signed-off-by: tomersein <[email protected]>
@tomersein
suggest fixed version
dee67ff 
Signed-off-by: tomersein <[email protected]>
@tomersein tomersein changed the title Sort fixed version according to the package version add suggested fixed version Jan 4, 2025
@tomersein
suggest fixed version
681ec3e 
Signed-off-by: tomersein <[email protected]>
@tomersein
Copy link
Contributor Author

hi @willmurphyscode
added a new field inside match details as you suggested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willmurphyscode willmurphyscode willmurphyscode left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomersein @willmurphyscode