Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore linux-aws-headers-.* as well like linux-headers-.* #2295

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

barnuri
Copy link
Contributor

@barnuri barnuri commented Dec 3, 2024

Linux headers are already being ignored, however, there are some that appear to be unintentionally included. This PR addresses this by loosening the pattern used to ignore linux header packages.

@barnuri barnuri changed the title ignore linux-aws-headers-.* as well like linux-headers- ignore linux-aws-headers-.* as well like linux-headers-.* Dec 3, 2024
@popey
Copy link
Contributor

popey commented Dec 3, 2024

Hi @barnuri - thanks for the PR!

I looked at my Ubuntu 24.04 laptop, and as well as the AWS kernel headers, there are packages for other cloud providers. Is it worth adding these too?

linux-azure-headers-*
linux-gcp-headers-*
linux-gke-headers-*
linux-gkeop-headers-*
linux-ibm-headers-*
linux-intel-headers-*
linux-lowlatency-headers-*
linux-oracle-headers-*
linux-riscv-headers-*
linux-xilinx-headers-*

Plus some other random ones like:

linux-nvidia-headers-*
linux-nvidia-lowlatency-headerrs-*
linux-oem-*-headers-*

@barnuri
Copy link
Contributor Author

barnuri commented Dec 3, 2024

Hi @barnuri - thanks for the PR!

I looked at my Ubuntu 24.04 laptop, and as well as the AWS kernel headers, there are packages for other cloud providers. Is it worth adding these too?

linux-azure-headers-*
linux-gcp-headers-*
linux-gke-headers-*
linux-gkeop-headers-*
linux-ibm-headers-*
linux-intel-headers-*
linux-lowlatency-headers-*
linux-oracle-headers-*
linux-riscv-headers-*
linux-xilinx-headers-*

Plus some other random ones like:

linux-nvidia-headers-*
linux-nvidia-lowlatency-headerrs-*
linux-oem-*-headers-*

hi probably, maybe change it to linux-.*-headers-.*
i faced only with linux-aws-headers-.*

@wagoodman wagoodman added the bug Something isn't working label Dec 4, 2024
@wagoodman wagoodman merged commit 40a948d into anchore:main Dec 4, 2024
10 checks passed
@barnuri barnuri deleted the patch-2 branch December 4, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants