Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Long namespace/service names break up thing in many places #25

Open
Hi-Fi opened this issue Jan 17, 2022 · 0 comments
Open

BUG: Long namespace/service names break up thing in many places #25

Hi-Fi opened this issue Jan 17, 2022 · 0 comments

Comments

@Hi-Fi
Copy link
Contributor

Hi-Fi commented Jan 17, 2022

There has been quite many times, when Kolga's way of generating names has hit severely to deployment, one e.g. https://github.com/City-of-Helsinki/yjdh/runs/4837858868?check_suite_focus=true:

Error: rendered manifests contain a resource that already exists. Unable to continue with install: NetworkPolicy "hl-365-automated-message-when-application-reopened-y-net-policy" in namespace "yjdh-hl-365-automated-message-when-application-reopened-638" exists and cannot be imported into the current release: invalid ownership metadata; annotation validation error: key "meta.helm.sh/release-name" must equal "hl-365-automated-message-when--review-yjdh-bf-bknd": current value is "hl-365-automated-message-when--review-yjdh-bf-appl"

Max length of all possible generated name parts should be determined, and e.g. hashed to be short enough. Now it seems that name lenght comes back quite often.

E.g. https://github.com/City-of-Helsinki/review-services-action/blob/main/src/utils.ts#L7-L20 has of course easier job as there's only one name to generate, but in Kolga's case it would be enough to take the "worst" case. Usually namespace tells the deployment/app, so pod doesn't necessarily have to repeat that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant