Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension crashes with indicator.get_parent() is null #22

Open
twalkerA opened this issue Jun 20, 2024 · 3 comments
Open

Extension crashes with indicator.get_parent() is null #22

twalkerA opened this issue Jun 20, 2024 · 3 comments

Comments

@twalkerA
Copy link

Hello Andia89,

Within the last two weeks the extension has been crashing. It seems to happen after I unlock my screen. The error in Extension Manager is "indicator.get_parent() is null"

I am using Ubuntu 22.04lts.

Thanks for creating this extension. And, thank you for looking into this issue.

@oskarnrk
Copy link

It happens to me too on Fedora 40 with Gnome 46.
Some log from journalctl of it can help.

gnome-shell[6145]: Object St.Bin (0x561357ff5810), has been already disposed — impossible to access it. This might be caused by the object having been destroyed from C code using something such as destroy(), dispose(), or remove() vfuncs.
                                             == Stack trace for context 0x56135795b900 ==
                                             #0   7ffef1331330 b   file:///home/<user>/.local/share/gnome-shell/extensions/[email protected]/extension.js:94 (3e037e4d4e20 @ 219)
                                             #1   561357a22008 i   resource:///org/gnome/shell/ui/init.js:21 (37d074570bf0 @ 48)
audit[6145]: ANOM_ABEND auid=1000 uid=1000 gid=1000 ses=3 subj=unconfined_u:unconfined_r:unconfined_t:s0-s0:c0.c1023 pid=6145 comm="gnome-shell" exe="/usr/bin/gnome-shell" sig=11 res=1
kernel: show_signal_msg: 47 callbacks suppressed
kernel: gnome-shell[6145]: segfault at 8 ip 00007f2d454b3af0 sp 00007ffef1330c70 error 6 in libmutter-clutter-14.so.0.0.0[3baf0,7f2d4549d000+8f000] likely on CPU 4 (core 8, socket 0)

@roland65
Copy link

roland65 commented Oct 8, 2024

Same problem for me. Same error message. My gnome-shell crashes once a day due to this problem.
Gnome 46, Ubuntu 24.04.

@roland65
Copy link

roland65 commented Oct 30, 2024

I tried the following patch.
In extension.js, replace:

        let box = indicator.get_parent().get_parent();
        if (box == undefined) continue
        this._addToPanelBox(role, indicator, 0, box)

With:

 if (indicator.get_parent() != null)
        {        
            let box = indicator.get_parent().get_parent();
            if (box == undefined) continue
            this._addToPanelBox(role, indicator, 0, box)
        }

I got no crash since.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants