Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add standard note for non-standard rechargeable batteries and nonstandard irreplaceable batteries #80

Closed
3 tasks done
kaosmagix opened this issue Dec 17, 2023 · 8 comments

Comments

@kaosmagix
Copy link
Contributor

Checklist

  • I have filled out the template to the best of my ability.
  • This only contains 1 feature request (if you have multiple feature requests, open one feature request for each feature request).
  • This issue is not a duplicate feature request of previous feature requests.

Is your feature request related to a problem? Please describe.

For consistency add standard battery types for non-standard battery rechargeable devices like Ring doorbell and non-standard irreplaceable batteries like smoke detectors to allow all battery devices to auto discover battery notes.

Functionality is already there it is more a question on defining a "standard" battery type label for these types. This to add them in a consistent way to the library.

Describe the solution you'd like

new labels:

  • Non-standard rechargeable battery
  • Irreplaceable battery

Describe alternatives you've considered

Manual entry without auto discovery

Additional context

I like all my battery devices linked where possible as that provides a way to create a singe list of batteries and near future replacements

@andrew-codechimp
Copy link
Owner

I think you'd want to keep these fairly short so they don't crop/wrap in small views.

Maybe just Rechargeable and Irreplaceable ?

@kaosmagix
Copy link
Contributor Author

The short label Sounds good. It is just something you need to add to the documentation and the issue form to create consistency in database entries

@kaosmagix
Copy link
Contributor Author

Added a few devices with rechargeable batteries (Ring doorbell) and irreplaceable batteries (Heiman smoke sensor)

@codyc1515
Copy link
Contributor

Could just be Replaceable = Yes / No

@klaptafel
Copy link
Contributor

This is interesting. However how would that work when the power source could be different for a device? For example the Hunter Douglas Duette has a configurable power source; either a battery wand (12 x AA), Rechargeable or Hardwired.

Screenshot 2023-12-18 om 09 31 02@2x

@andrew-codechimp
Copy link
Owner

I don't think we're going to cover every option here and I'd rather not increase the schema for very unusual cases.
I'll go with Rechargeable/Irreplaceable as options and add to readme.
There will always be the option to overwrite the library value.

@codyc1515
Copy link
Contributor

How is hard wired relevant to this? There would be no relevance to a battery in that case.

@andrew-codechimp
Copy link
Owner

I see @WendelFelius point, if it's in the library as Rechargeable but you happen to have your device Hard Wired the library will suggest the wrong value. Why I'm always going to get you to confirm the battery type on discovered items so you can make a sensible choice for your own use.
As an example, where I have AA rechargeable's in use I'll put 2x AA(r) for my own purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants