-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add standard note for non-standard rechargeable batteries and nonstandard irreplaceable batteries #80
Comments
I think you'd want to keep these fairly short so they don't crop/wrap in small views. Maybe just Rechargeable and Irreplaceable ? |
The short label Sounds good. It is just something you need to add to the documentation and the issue form to create consistency in database entries |
Added a few devices with rechargeable batteries (Ring doorbell) and irreplaceable batteries (Heiman smoke sensor) |
Could just be Replaceable = Yes / No |
I don't think we're going to cover every option here and I'd rather not increase the schema for very unusual cases. |
How is hard wired relevant to this? There would be no relevance to a battery in that case. |
I see @WendelFelius point, if it's in the library as Rechargeable but you happen to have your device Hard Wired the library will suggest the wrong value. Why I'm always going to get you to confirm the battery type on discovered items so you can make a sensible choice for your own use. |
Checklist
Is your feature request related to a problem? Please describe.
For consistency add standard battery types for non-standard battery rechargeable devices like Ring doorbell and non-standard irreplaceable batteries like smoke detectors to allow all battery devices to auto discover battery notes.
Functionality is already there it is more a question on defining a "standard" battery type label for these types. This to add them in a consistent way to the library.
Describe the solution you'd like
new labels:
Describe alternatives you've considered
Manual entry without auto discovery
Additional context
I like all my battery devices linked where possible as that provides a way to create a singe list of batteries and near future replacements
The text was updated successfully, but these errors were encountered: