Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use TOP_ALWAYS in setAlwaysDisplayTabMode(boolean) #267

Open
andrewauclair opened this issue Jan 27, 2025 · 0 comments
Open

Use TOP_ALWAYS in setAlwaysDisplayTabMode(boolean) #267

andrewauclair opened this issue Jan 27, 2025 · 0 comments
Labels
bug Something isn't working fixed Issue has been fixed, pending release.

Comments

@andrewauclair
Copy link
Owner

This method is being removed when 1.1 comes around, but for now I want to make sure it has an accurate implementation in the new tab implementation when compared to how setAlwaysDisplayTabMode worked in 0.11 and older releases.
@andrewauclair andrewauclair added the bug Something isn't working label Jan 27, 2025
andrewauclair added a commit that referenced this issue Jan 27, 2025
@andrewauclair
Issue #267
5da90ba 
alwaysDisplayTabsMode and setAlwaysDisplayTabMode should have used TOP_ALWAYS instead of TOP.

When we remove these older functions, we might need to improve the API more to distinguish the uses of TOP_ALWAYS and BOTTOM_ALWAYS vs TOP and BOTTOM.
andrewauclair added a commit that referenced this issue Jan 27, 2025
@andrewauclair
Issue #267 (#277)
aa2ca02 
alwaysDisplayTabsMode and setAlwaysDisplayTabMode should have used TOP_ALWAYS instead of TOP.

When we remove these older functions, we might need to improve the API more to distinguish the uses of TOP_ALWAYS and BOTTOM_ALWAYS vs TOP and BOTTOM.
@andrewauclair andrewauclair added the fixed Issue has been fixed, pending release. label Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working fixed Issue has been fixed, pending release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andrewauclair