Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

object_hashes messages should only be sent after comparing object_hashes_hash (not relevant with today's link speeds and computer memory sizes) #8

Open
andrewhodel opened this issue Jul 7, 2022 · 0 comments

Comments

@andrewhodel
Copy link
Owner

andrewhodel commented Jul 7, 2022

object_hashes messages are sent after connection on an interval.

They contain a hash of each object that the node has.

They should be sent only after a comparison returns unequal for an object_hashes_hash message because there could be a billion objects (therefore a billion object hashes). This will make equal comparisons much faster across the network but is irrelevant at the link speeds of today and the computer memory sizes of today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant