Add playback commands #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
main.ts
Outdated
| id: "Play/Pause", | ||
| name: "Play/Pause current track", | ||
| callback: () => { | ||
| if (isTrackPlaying) { |
There was a problem hiding this comment.
Instead of introducing a new variable, you should be able to use:
if(this.localPlayerStateObservable.getValue().playerState === PLAYER_STATE.PLAYING)
in the previous commit, I was introducing a new global variable to know the state of the current track (whether it is playing or paused) but it seems like there is another way to do it without adding a new variable
|
hello @andrewmcgivery , I didn't know there was a simple way to know if the track is playing or not and that's why I introduced a new variable. |
|
ping @andrewmcgivery 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the implementation of the feature request #35 (I opened few hours earlier).
Adding commands to the plugin is useful because the user can control their playback without touching the mouse, they can use the command palette or assign hotkeys (keyboard shortcuts) to the commands.
Here is a breakdown of the changes:
this.addCommand({})for three different commands (play next track, play previous track, and toggle play/pause)this.next()andthis.previous()respectivelyI tested the changes and they all work fine
