Skip to content
This repository has been archived by the owner on Feb 12, 2021. It is now read-only.

Bump graceful-fs dependency (graceful-fs@2 and @3 support will be removed soon) #122

Open
ChALkeR opened this issue Feb 13, 2016 · 7 comments
Milestone

Comments

@ChALkeR
Copy link

ChALkeR commented Feb 13, 2016

graceful-fs versions lower than v4 reevaluate native fs module source, which is not supported.
You should update your graceful-fs dependency to v4 or later.

Tracking issue: nodejs/node#5213.

@keshavkaul
Copy link

👍

@asimo
Copy link

asimo commented Jun 9, 2016

+1 Thanks for the awesome work.

@krazik
Copy link

krazik commented Jun 16, 2016

👍

@jeroenrinzema
Copy link

+1

@ChALkeR
Copy link
Author

ChALkeR commented Aug 9, 2016

Hi.

graceful-fs@2 and @3 support will be removed soon.

s3 is currently #20 in my list of modules that would likely be broken when nodejs/node#6413 lands (which is anticipated to happen before v7.0).

Note that graceful-fs@1 and graceful-fs@4 are ok and would not be broken by this, but a require() on graceful-fs@2 or graceful-fs@3 would cause an error soon.

That is, runtime warning fs: re-evaluating native module sources is not supported. would be turned into a throw.

If you or your deps use graceful-fs@2 or graceful-fs@3 in runtime — you are affected.

Tracking: nodejs/node#5213.

@ChALkeR ChALkeR changed the title Bump graceful-fs dependency Bump graceful-fs dependency (graceful-fs@2 and @3 support will be removed soon) Aug 9, 2016
@yachaka
Copy link

yachaka commented Aug 11, 2016

+1

@yachaka
Copy link

yachaka commented Aug 11, 2016

Apparently, this is something that's already been changed in the actual commit. The graceful-fs version is 4.1.4, while it hasn't been changed in the npm package.

A publish from the author should be enough.

Meanwhile, I will be using this git repository as a dependency.

@OmgImAlexis OmgImAlexis modified the milestone: Backlog Aug 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants