Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent "generateBid" documentation #130

Open
guybashan opened this issue Nov 6, 2024 · 1 comment
Open

Inconsistent "generateBid" documentation #130

guybashan opened this issue Nov 6, 2024 · 1 comment

Comments

@guybashan
Copy link

Over here it shows the generateBid has 7 params:

https://developers.google.com/privacy-sandbox/private-advertising/protected-audience/android#ad-selection-buy-side-bidding

But in the actual example in the repository it shows only 6 params:

https://github.com/android/privacy-sandbox-samples/blob/main/Fledge/FledgeServerSpec/BiddingLogic.js

@c4mb0t
Copy link

c4mb0t commented Dec 17, 2024

For on-device auctions, the generateBid function supports either 7 or 6 parameters in the function signature:

generateBid(ad, auction_signals, per_buyer_signals, trusted_bidding_signals, contextual_signals, user_signals, custom_audience_bidding_signals)

or

generateBid(ad, auction_signals, per_buyer_signals, trusted_bidding_signals, contextual_signals, custom_audience_bidding_signals)

The Android platform will automatically detect which one you are using.

We're currently in the process of updating our docs to focus more on B&A server auctions rather than on-device, which should clear up this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants