Speaker does not have play(tone, duration) method

[tomaszrykala]

The readme for PWM Speaker describes an overloaded play() method that takes a tone and a duration as arguments. The driver however, supplies only a method that allows the tone.

readme source:
https://github.com/androidthings/contrib-drivers/tree/master/pwmspeaker

extract:

// Make it play:

try {
    mSpeaker.play(440 /* tone */, 3000L /* duration */);
} catch (IOException e) {
    // error setting speaker
}

The only currently existing method:

    public void play(double frequency) throws IOException, IllegalStateException {
...
    }

[proppy]

Sounds like a documentation bug :)

[tomaszrykala]

Can update the documentation to address this, but is there somehow we could expand on this, admiteddly not ideal, solution? #36

[tomaszrykala]

Thank you for the input. I will update the documentation in the meantime.

[mangini]

@tomaszrykala Supporting duration essentially means having a sequencer in a separate thread that handles the timers, so it's not trivial. We have an initial implementation in our internal code review. Can you open a separate "enhancement" issue so we can keep track of it? Thanks!

[tomaszrykala]

@mangini Here it is. #38 Thanks.

[tomaszrykala]

This is closed by #37