Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes for you, reformed Framework and Window a little bit, adds functionality to PipelineMaker #46

Open
timprepscius opened this issue May 30, 2022 · 1 comment

Comments

@timprepscius
Copy link
Contributor

timprepscius commented May 30, 2022

https://github.com/timprepscius/Vookoo/branches
tjp_remove_forced_multiview__pipeline_maker_options

Hey there,

I've made some changes basically summed up as:

  1. make DeviceMaker be more basic with defaultLayers, add functions to easily add VK_KHR_MULTIVIEW_EXTENSION_NAME, etc.
  2. make InstanceMaker be more basic with defaultLayers, add functions to easily add Geometry and Tesselation etc.
  3. make Framework take the DeviceMaker and InstanceMaker.
  4. add the ability to have no viewport and no scissor.

This allows more easily not having VK_KHR_MULTIVIEW_EXTENSION_NAME or Tessellation or GeometryShaders.

You will need to change bits of your code to have:


InstanceMaker im;
im
  .extensionMultiview();


DeviceMaker dm;
dm
  .extensionMultiview()
  .physicalDeviceFeatures()
  .enableGeometryShader()
  .enableTessellationShader()
  .multiviewFeatures()
  .enableMultiview();

Framework framework(im, dm);

But your code will actually be more descriptive by doing this as well.

Thank you very much for your code, especially vku.hpp.

@timprepscius
Copy link
Contributor Author

Also, your header files need to reference "vku.hpp" from vku_framework.hpp, not <vku.hpp>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant