Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vookoo will not run on Mac with Vulkan 1.3.216. #55

Open
FunMiles opened this issue Dec 14, 2023 · 1 comment
Open

Vookoo will not run on Mac with Vulkan 1.3.216. #55

FunMiles opened this issue Dec 14, 2023 · 1 comment

Comments

@FunMiles
Copy link
Contributor

When installing Vulkan SDK 1.3.216 or after on MacOS, the following appears:

NOTICE: As of the 1.3.216 SDK release,  the Vulkan Portability Enumeration extension is being enforced by the Vulkan loader.  Failure to 'opt in' for non-conformant Vulkan implementations will cause applications to fail to find the MoltenVK ICD.  See the macOS release notes for more information.

Indeed the code will not run anymore.
Fixing it requires a few changes: adding more layers to the default:

    instance_extensions_.push_back(VK_KHR_PORTABILITY_ENUMERATION_EXTENSION_NAME);
    instance_extensions_.push_back(VK_KHR_GET_PHYSICAL_DEVICE_PROPERTIES_2_EXTENSION_NAME);

and a flag when calling InstanceCreateInfo:

vk::InstanceCreateFlagBits::eEnumeratePortabilityKHR

Unfortunately, some of these constants are not available with the glfw provided Vulkan headers. Updating the version of glfw is also necessary.
I will create a PR for this issue.

@FunMiles
Copy link
Contributor Author

PR #56 fixes the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant