Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aabb calc fix in mesh, and a few compilation issues on osx (yosemite) #3

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

colormotor
Copy link

No description provided.

@andy-thomason
Copy link
Owner

Many thanks for this.

The vmax issue is clearly a bug.
I would rather use plain old (int) casts (Call me old fashioned)
std::sqrt is not the same as sqrt as sqrt works on double precsion which is very slow sqrtf is more correct or include cmath header.

I'll submit another changelist for this.

@colormotor
Copy link
Author

happy it helps!
Actually the other two modifications were just quick work-arounds because XCode was complaining (probably because my project settings are not correct).
I definitely prefer good old casts as well :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants