Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Divider height #20

Closed
ivanmem opened this issue Apr 27, 2024 · 2 comments
Closed

Divider height #20

ivanmem opened this issue Apr 27, 2024 · 2 comments

Comments

@ivanmem
Copy link

ivanmem commented Apr 27, 2024

Currently, the library has a dividerWidth property, which is similar to the thickness of a divider. However, the term is misleading, as it actually refers to the width of the line, not the separator itself.

Are there plans to introduce a property similar to Divider height, which would allow us to set the actual width of the divider, potentially making it larger than the divider's size?

@ivanmem ivanmem changed the title Divider width Divider height Apr 27, 2024
@ivanmem ivanmem changed the title Divider height Divider indent Apr 27, 2024
@ivanmem ivanmem changed the title Divider indent Divider height Apr 27, 2024
@andyhorn
Copy link
Owner

andyhorn commented May 8, 2024

This has been added in #26 - however, I used the terminology thickness to refer to the thickness of the visible line and size to refer to the total space taken up by the divider. Does that work?

I didn't want to use height or width because the divider can be horizontal or vertical, so the best I could come up with was size.

@andyhorn
Copy link
Owner

andyhorn commented May 9, 2024

This was included with release 1.0.0

@andyhorn andyhorn closed this as completed May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants