-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Next.js Example Repo #1
Comments
Yes, fair (see 2nd TODO at top of Readme 😉 ) I was essentially lazy-executing those tasks conditional upon someone showing interest in it being worthwhile. Instructions are up-to-date but not necessarily error/omission-free - you're probably the first to try following them 🙏 Feel free to share any context on the issues you hit, and separately I'll try pull together a working example - hopefully within the next day or two. |
Ah, yes haha! Didn't catch that
I ran into this exact issue when integrating inngest into one of my projects, which then made me want to implement edge.
Will do and that would be amazing. That is the big downside to the data proxy rn and I'm surprised they released it without having a way to develop on a local db with it 😂 |
@masnwilliams Next.js example added, let me know if you run into issues with it. Still TODO: update the Readme with a few corrections discovered while creating the example 🙈 - basic structure still applies, just some typos in the code snippets with incorrect variable names etc causing the code not to work. |
Amazing!! Will try it out tonight and let you know how it goes 👍 |
Then once those are solved, I am still getting this error:
|
Gah - I believe I fixed these errors but critically disguised the update to the library code within my commit adding the example (and didn't republish to npm). So I suspect you didn't pull the updated version? Does checking out the repo and running the example as-is work for you? Should fix that Datasource URL error also.
It should be possible to get this approach working with any framework/router.. although I published v0.1 to npm, it's definitely still proof-of-concept rather than fully-fledged library yet. Needs transpiling to a javascript dist build for starters; also no need to depend on Next.js, the server script can be updated to work under any plain Node server (by removing use of the Next.js request/response helpers). |
Updated readme, tidied a bit more, published v0.2.0 to npm |
Agreed, I think this will be the step needed to make this work for a far larger audience. I'm still getting a type error in
|
Also getting a webpack error, which I think its from transpiling the package?
Another thing was that I had to install |
Good news is that I am able to detect my inngest server, just need to nail down some small issues and it should be pretty solid! |
Yes, the current server implementation is for the Next.js
Ah yes - I have that as a devDependency for types but since the package is currently published with the typescript rather than transpiled javascript it needs to be moved to a normal dependency (or just add javascript transpiling). Mostly offline until Monday now but will follow up to incorporate this feedback. Cheers! |
I think it might help if you could link to an example repo that has everything set up in it. This is almost always the best way to display how a project like this is set up.
I tried following the instructions but ran into issues along the way. (maybe the instructions are out of date?)
The text was updated successfully, but these errors were encountered: