Skip to content

Commit

Permalink
google_audio_processing: Fix kconfig precedence for MOCK
Browse files Browse the repository at this point in the history
At some point the "mock" feature here got folded into COMP_STUBS,
which is a more general tunable.  But it was done with a kconfig
"select" and not a default, which meant that it was no longer possible
to disable the mock when AEC was enabled without changing COMP_STUBS
globally, which hurts debugging.

Put the handling in a default on the variable instead, now it can be
overridden by later stages of kconfig (like the board conf file or the
command line of xtensa-build-zephyr.py).

Signed-off-by: Andy Ross <[email protected]>
  • Loading branch information
andyross committed Dec 12, 2023
1 parent 8b8c153 commit b8ccd86
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/audio/google/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ config COMP_GOOGLE_HOTWORD_DETECT
config COMP_GOOGLE_RTC_AUDIO_PROCESSING
bool "Google Real Time Communication Audio processing"
select COMP_BLOB
select GOOGLE_RTC_AUDIO_PROCESSING_MOCK if COMP_STUBS
default n
help
Select for Google real-time communication audio processing. It
Expand Down Expand Up @@ -75,7 +74,7 @@ config COMP_GOOGLE_RTC_AUDIO_PROCESSING_MIC_HEADROOM_LINEAR

config GOOGLE_RTC_AUDIO_PROCESSING_MOCK
bool "Google Real Time Communication Audio processing mock"
default n
default y if COMP_STUBS
depends on COMP_GOOGLE_RTC_AUDIO_PROCESSING
help
Mock Google real-time communication audio processing.
Expand Down

0 comments on commit b8ccd86

Please sign in to comment.