Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HE.net authentication & domain not found error message #7

Open
danielmotaleite opened this issue Jun 8, 2020 · 3 comments
Open

HE.net authentication & domain not found error message #7

danielmotaleite opened this issue Jun 8, 2020 · 3 comments

Comments

@danielmotaleite
Copy link

Script is failing with
No zone for domain "" found.

Checking the script we get that the cookie format changes, we do not have anymore the CGISESSID cookie, but instead a random id:

 curl -L --silent --show-error -I https://dns.he.net/ |  grep '^Set-Cookie:' 
Set-Cookie: 2915s1a0a47538f8ae75fdef12aca44c56e2b307832d37d25210ba8ed950c3e4=15425ee4e6df96e0c0d23acc4213eb37; path=/; expires=Tue, 09-Jun-2020 10:32:26 GMT
@danielmotaleite
Copy link
Author

This PR seems to fix this:
#6

@zaszlo
Copy link

zaszlo commented Jul 7, 2020

Can confirm, that without that PR modification the script was failing, using its corrections is working.

Also on line 99 the return should be changed to exit, as that is an exit code and return can be used only from a function.
I was also getting this error:
/root/certbot-he-hook.sh: line 99: return: can only `return' from a function or sourced script

BR!

@NetForces
Copy link

I can also confirm that I was able to get wildcard certs with this patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants