Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge of Liblinear with sample weights version #8

Open
simsong opened this issue Jan 22, 2018 · 1 comment
Open

Merge of Liblinear with sample weights version #8

simsong opened this issue Jan 22, 2018 · 1 comment

Comments

@simsong
Copy link

simsong commented Jan 22, 2018

From @seanv507 on March 26, 2017 18:34

Hi, I would like to work on merging the sample weights version. Can you provide some guidance in terms of your own requirements?
My final goal is having a sample weights version in R (based on https://cran.r-project.org/web/packages/LiblineaR/index.html)
I have done the majority of the work,
but there are a few sticking points:

a) adding sample weights 'breaks' the interface for eg matlab and python versions
b) should one change the code to always use sample weights, or is the added computational cost too great?
c) currently I have merged the c++ code using conditional compilation because of b), however, this does not work for python and R (no conditional compilation), so it raises the worry of python/R code calling the library with the wrong compilation options.

eg I could

Copied from original issue: cjlin1#32

@seanv507
Copy link

This contains my code version
https://github.com/seanv507/LiblineaR-1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants