Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM package peer dependencies #19

Closed
nicorac opened this issue May 25, 2023 · 3 comments
Closed

NPM package peer dependencies #19

nicorac opened this issue May 25, 2023 · 3 comments

Comments

@nicorac
Copy link

nicorac commented May 25, 2023

I had a lot of issues installing this package (required by a third-party component...) because of the strict versions declared as peer dependencies in package.

Example: it requires @angular/router: "16.0.0", but I actually have 16.0.3 installed...

It forced me to use the --legacy-peer-deps npm option to complete the installation.

  "peerDependencies": {
    "@angular/common": "^15.1.0 || ^16.0.0",
    "@angular/core": "^15.1.0 || 16.0.0",
    "three": "^0.148.0 || ^0.149.0 || ^0.150.0 || ^0.151.0 || ^0.152.0",
    "rxjs": "7.8.0",
    "@angular/router": "16.0.0"
  },

IMHO it should read like this (added ^ prefix to @angular/core, rxjs and @angular/router versions):

  "peerDependencies": {
    "@angular/common": "^15.1.0 || ^16.0.0",
    "@angular/core": "^15.1.0 || ^16.0.0",
    "three": "^0.148.0 || ^0.149.0 || ^0.150.0 || ^0.151.0 || ^0.152.0",
    "rxjs": "^7.8.0",
    "@angular/router": "^16.0.0"
  },
@SKaDiZZ
Copy link

SKaDiZZ commented Jun 7, 2023

I'm, having the same issue hope you'll find time to fix it because using --force or --legacy-peer-deps isn't exactly a solution

@nicorac
Copy link
Author

nicorac commented Jul 7, 2023

Is anyone taking care of this?
I could open a PR for it... but I see there's one waiting till 2023-05-19 🤔...

@nartc nartc closed this as not planned Won't fix, can't repro, duplicate, stale Jul 30, 2024
@nicorac
Copy link
Author

nicorac commented Jul 31, 2024

Can't wait for #35 to complete then...😉
Keep up the good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants