Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The pre-commit hooks fails to validate this repo format #54

Open
vicb opened this issue Mar 28, 2018 · 0 comments
Open

The pre-commit hooks fails to validate this repo format #54

vicb opened this issue Mar 28, 2018 · 0 comments
Labels
enhancement

Comments

@vicb
Copy link
Contributor

vicb commented Mar 28, 2018

  1. run ./bin/darwin_x64/clang-format -i -style=file index.js bin/check-clang-format.js
  2. yarn precommit fails (And is executed as a pre-commit hook).

I'll go ahead and disable the pre-commit hook for now to unblock the development.

We should re-enable later.
vicb added a commit to vicb/clang-format that referenced this issue Mar 29, 2018
@vicb
fix: the pre-commit hook fails to validate code formatting
05ca57b 
see angular#54
vicb added a commit to vicb/clang-format that referenced this issue Mar 29, 2018
@vicb
fix: the pre-commit hook fails to validate code formatting
c86f0c8 
see angular#54
mprobst pushed a commit that referenced this issue Apr 3, 2018
@vicb @mprobst
fix: the pre-commit hook fails to validate code formatting
797c0fa 
see #54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vicb