Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payload in voucher_status example in A.2 to be updated #50

Closed
EskoDijk opened this issue Apr 16, 2020 · 4 comments
Closed

Payload in voucher_status example in A.2 to be updated #50

EskoDijk opened this issue Apr 16, 2020 · 4 comments

Comments

@EskoDijk
Copy link
Collaborator

In -07, payload decodes to:

{"version": "1", "Status": 1, "Reason": "Informative human readable message", "reason-context": "Additional information"}

which should be (per BRSKI-41):

{"version": "1", "status": false, "reason": "Informative human readable message", "reason-context": { "additional" : "JSON" } }

(status is changed to 'false' here, to encode an error status. If no error, there should be no 'reason' field as well. Also the additional-information is updated with a more clear example, but this is not super important to have. But it's more in line with BRSKI.

Also a success example could be added if needed:
{"version": "1", "status": true}

@EskoDijk
Copy link
Collaborator Author

See also #47 for more info

@EskoDijk
Copy link
Collaborator Author

See also anima-wg/anima-bootstrap#144 for related issues in BRSKI. We should capture the outcome of this discussion in the constrained-voucher draft.

@mcr
Copy link
Member

mcr commented Nov 26, 2020

@petervanderstok , how did you create this example?

@petervanderstok
Copy link

petervanderstok commented Nov 26, 2020 via email

@mcr mcr closed this as completed in 8e8f7b6 Nov 26, 2020
mcr added a commit that referenced this issue Nov 26, 2020
updated voucher_status example, close #50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants