-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All videos within a folder get the same metadata #47
Comments
Which version of the plugin are you on? This was a big in an earlier
version.
I will be taking some time to add debug logs in soon to help with others
who have had issues lately. Been getting ramped up at a new place so I have
not had much time to work on the plugin. Expect to get some time this week
though.
…On Sat, Apr 30, 2022, 12:41 PM GiovanH ***@***.***> wrote:
I have youtube videos arranged by channel, with the IDs in square brackets
and accompanying info.json files:
[image: image]
<https://user-images.githubusercontent.com/6759280/166120231-80dc5d86-6157-4546-8c01-b3ad41c3131a.png>
But when jellyfin runs, the youtube provider gives every video in the
folder the same metadata, even though the info.json files are correct:
[image: image]
<https://user-images.githubusercontent.com/6759280/166120283-5be33e8c-e4a5-44fc-ada8-e79ed6b47aa6.png>
I haven't been able to find much in the way of logs to debug this, so any
pointers would be greatly appreciated.
—
Reply to this email directly, view it on GitHub
<#47>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALYWLSH5FY3YMN7A7ANRRLVHWEGPANCNFSM5UYYLJNA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
This is on version 1.0.3.5 on Jellyfin 10.8 |
Weird, I will have to check my own server when I get home because I also
have petscop.
…On Sat, Apr 30, 2022, 2:23 PM GiovanH ***@***.***> wrote:
This is on version 1.0.3.5 on Jellyfin 10.8
—
Reply to this email directly, view it on GitHub
<#47 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALYWLUXVYGY2ULMP2CVUEDVHWQDZANCNFSM5UYYLJNA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
To be clear, this isn't limited to petscop; that was just the example I was using. This is a global problem. |
I'd like to echo the same problem. Every one of my videos is named as instructed, but they all have the same metadata - minus the thumbnail. Jellyfin Version: 10.8.0 Plugin Version: 1.0.3.5 |
Also, the log output on the console reads
I think this is just bad code here Line 66 in 8dfdb60
I don't have a .NET environment or I'd get in there myself, but I don't think this debug logging ever worked |
I have the same problem each one of the videos in the same folder all have the same metadata. Plugin version: 1.0.3.5 |
Just uploaded a new version, I believe there are still some bugs that need to be worked out but the duplicate episodes thing should be resolved. |
If it's not 1.0.3.6, the build from 3 days ago, I'll check it out once I see it install and confirm. Im getting Status: Not Supported by the plugin now. 1.0.3.6, JF version 10.8.0 |
That seems to have broken the plugin entirely.
|
Sorry, can you be more explicit? What cause it to fail entirely?
…On Sun, May 8, 2022, 7:45 PM GiovanH ***@***.***> wrote:
That seems to have broken the plugin entirely.
[02:42:54] [ERR] [1] Emby.Server.Implementations.Plugins.PluginManager: Failed to load assembly /config/plugins/YoutubeMetadata_1.0.3.6/Jellyfin.Plugin.YoutubeMetadata.dll. This error occurs when a plugin references an incompatible version of one of the shared libraries. Disabling plugin.
System.Reflection.ReflectionTypeLoadException: Unable to load one or more of the requested types.
Method 'ExecuteAsync' in type 'Jellyfin.Plugin.YoutubeMetadata.EpisodeIndexer' from assembly 'Jellyfin.Plugin.YoutubeMetadata, Version=1.0.3.6, Culture=neutral, PublicKeyToken=null' does not have an implementation.
at System.Reflection.RuntimeModule.GetTypes(RuntimeModule module)
at System.Reflection.Assembly.GetTypes()
at Emby.Server.Implementations.Plugins.PluginManager.LoadAssemblies()+MoveNext()
System.TypeLoadException: Method 'ExecuteAsync' in type 'Jellyfin.Plugin.YoutubeMetadata.EpisodeIndexer' from assembly 'Jellyfin.Plugin.YoutubeMetadata, Version=1.0.3.6, Culture=neutral, PublicKeyToken=null' does not have an implementation.
—
Reply to this email directly, view it on GitHub
<#47 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALYWLSN25YGEMXPAHVR6V3VJB325ANCNFSM5UYYLJNA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
I attached the exact log above. It fails to load on program start. |
Ok but I still need to understand what version you are running down to specific builds. I was targeting the latest alpha (5) for building against. Searching the issues on Jellyfin it seems like maybe you are running unstable? jellyfin/jellyfin#7351 |
So what specific version/tag of jellyfin does this target? I don't see anything in the readme requirements |
? |
I also have this issue with jellyfin 10.8.0 and plugin version 1.0.3.7 |
|
Same |
Also experiencing the issue with Jellyfin 10.8.0 and plugin 1.0.3.7 Have noticed the YT MetaData field is empty within Jellyfin. Manually adding the YT video ID and refreshing the metadata resolves the issue. Obviously not a solution, but possibly the source of the problem that the plugin isn't either adding or extracting the YT ID correctly. [Edit] |
This is super weird because I haven't been able to replicate this since
early in the development. If you understand that this is replicable can
someone who possibly has a dockerized version or can just launch a second
instance of jelly fin do that? Basically what I'm looking for is given the
file structures being exactly the same, given a new instance and a fresh
database with nothing else being created will it do the same. If someone
can do that and confirm that replicates that would be very helpful.
…On Wed, Jun 15, 2022, 2:14 AM iamdangry ***@***.***> wrote:
Also experiencing the issue with Jellyfin 10.8.0 and plugin 1.0.3.7
Have noticed the YT MetaData field is empty within Jellyfin. Manually
adding the YT video ID and refreshing the metadata resolves the issue.
Obviously not a solution, but possibly the source of the problem that the
plugin isn't either adding or extracting the YT ID correctly.
—
Reply to this email directly, view it on GitHub
<#47 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALYWLVCPTIKY5FRC6K6E7TVPGNHPANCNFSM5UYYLJNA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Did a completely fresh install for you, and still seeing the same problem. yt-dlp is installed in the container, and it is grabbing stuff like channel logos correctly, but episode names are still borked. File path looks like: "Brandon_Sanderson\2020_Creative_Writing_Lectures[PLSH_xM-KC3Zv-79sVZTTj-YA6IAqh8qeQ]\Brandon Sanderson - 20200122 - Lecture #1 Introduction — Brandon Sanderson on Writing Science Fiction and Fantasy [-6HOdHEeosc].mkv/.info.json/.nfo/.jpg" Similar structure for all of my sources. Weird thing is that some of them view each file as a different version of one episode, where others show each individual episode with the right thumbnail, but wrong title/info. |
This might require a different issue but @HStep20, why is your directory structure like that? For myself I use https://github.com/TheFrenchGhosty/TheFrenchGhostys-Ultimate-YouTube-DL-Scripts-Collection as my basis and it ends up with an output like Are you expecting playlists to be generated for you via my plugin, or another? Do others here have vastly different directory trees than what I have described above? |
Also for each person, what tools besides yt-dlp are you using? TubeArchivist? Something else? |
Seems to be working better now, I'll keep poking at it |
yt-dlp only Filetree was Placing each video into its own folder like |
A lot of the metadata is right now, but the season and episode numbers are locked at 1, so petscop is still all screwed up since it's sorting by title lexographically. |
Sorted two channels worth of videos using the new directory structure above |
but unsorted ones magically started working? Did all videos get resolved or just some? |
Correct. All videos within my YT library, whether sorted or unsorted, now have the correct metadata (except for the episode number issue mentioned by GiovanH). Will try to recreate the issue using the videos I've sorted and post any log entries |
So I've been fiddling for a few hours with a new library. Directory structure is important and the issue appears if I have more than 2 videos NOT contained in their own subfolders. What produced the issue:More than 2 videos NOT in their own subfolders and running "Refresh Metadata". Running "Replace Metadata" resolved the incorrect metadata until the next "Refresh Metadata" was ran.
OR
But when I added a third video, the metadata issue returned when using "Refresh Metadata":
OR
What resolved the issue:All videos being in their own subfolder - didn't matter if I ran "refresh metadata" or "replace metadata", videos recieved correct metadata My folder structure now: What I hadn't picked up on earlier is the issue going away when running "Replace" instead of "Refresh" when there was more than 2 videos not in their own subfolder. Hence the odd magical fix. Episode numbers are still all showing as 1. Did have one refresh where that resolved itself, but forgot to note it down. Will keep hunting on that one |
I just came back to my library (which had retrieved correct metadata) and found that it rescanned overnight and replaced that good metadata with bad metadata (all the same). My folder structure is |
Nope, not expecting playlists. Just using it to help with identification. Im using TubeSync, which lets you define patterns for naming of downloads since the TubeArchivist naming system doesnt work with this plugin. For all of my series, the naming scheme is set up to look like: "{Channel_Name}/{Playlist_Title}[Playlist_Key]/{Channel_Name} - {yyyymmdd} - {title_full} [{key}].{ext}" |
@ankenyr Please take a look at @iamdangry 's comment; it looks like this is a bug related to folder structure, so knowing that may make it easier to fix. Actually keeping each video in its own folder doesn't work, because it gives every video its own season. |
So far I have not been able to replicate this on Windows where I do my general development. I may have replicated this on Linux in docker but the server is frozen and I need to hit the hay. Will check it tomorrow. For anyone having this issue, is anyone on Windows by any chance? |
I'm on Windows and can confirm that the issue exists there too. iamdangry's fix of putting every video in its own subfolder worked for me, aside from the aforementioned issue of episodes sorting alphabetically by title instead of chronologically by date. My folder prior to giving every video its own folder was: Channel [ID]/Videos/Upload Date - Title [ID].ext Windows 10 Pro, Jellyfin 10.8.0, plugin version 1.0.3.7 |
My main Jellyfin server is Ubuntu 20.04.4 I've just spun up a Windows 10 Pro box (20H2) and can confirm this issue exists on Windows and goes away using the folder structure I wrote above. Working on updating it to the latest version of Win10 to see if the problem still exists [Edit] |
Ok I think I replicated it but I am seeing something slightly different. I think this may have to do with the sorting as mentioned by @BlueRocketMouse. I am unsure how to sort by other means as mentioned. I will take a look and see what is causing this but I suspect that the answer here may be that a "season folder" of some sort is required. |
My output looks even worse than yours.
|
Nope, mine all have a value in description |
can you give me the tree structure and images similar to GiovanH above? |
I'm using a new structure as I've documented further up in this thread so it works for now. I've listed both my work structure and non-working structure What works:Note: The season folder only exists to prevent a new season being created for each video. It has no impact on the issue
What doesn't work:
|
@iamdangry When I first put the files in place and scan I see what you are seeing but after the first run of the plugin they are fixed. |
Surprise I see this issue was filed a a couple weeks ago, it popped up in discussion in the dev channel. In all honesty this is all looking to be issues internal to jellyfin itself. When looking at the petscop media my plugin does return a empty string. I was suspecting it may have not actually added anything for Overview which could have caused a problem. This all feels to me like internal issues to Jellyfin itself sadly which is not something I can fix. I am sorry. I will try to investigate a bit more and make an issue on the jellyfin repo. |
I have never seen the "version" case you're describing. That seems unrelated to the issue I reported here. Videos need to pull their metadata from the appropriately named .info.json file without requiring a folder for each individual video. That's a plugin issue. |
Kept debugging, seems it is on me. I stepped through the yt-dl plugin until it exited into the metadata service file. I followed it down and noticed a line. Specifically the issue is Running a refresh and the youtube metadata task to renumber the episodes it now looks right to me. |
This has been released in the latest as #40 will take a bit more work than I thought. |
Thanks I will try it out
…-------- Original Message --------
On May 8, 2022, 2:58 PM, Rob Ankeny wrote:
Just uploaded a new version, I believe there are still some bugs that need to be worked out but the duplicate episodes thing should be resolved.
—
Reply to this email directly, [view it on GitHub](#47 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AOHAAP2VOJSNCVZGPMWAJU3VJA2G7ANCNFSM5UYYLJNA).
You are receiving this because you commented.Message ID: ***@***.***>
|
For those who have not shared yet, what do some of your filename formats
look like? The same as OPs?
…On Tue, Jun 14, 2022, 7:51 PM nothing2obvi ***@***.***> wrote:
I also have this issue with jellyfin 10.8.0 and plugin version 1.0.3.7
Same
—
Reply to this email directly, view it on GitHub
<#47 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALYWLXSSN7JM534XEWEZ3TVPFALDANCNFSM5UYYLJNA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
I believe I said alpha 5 in the previous message. Are you running unstable
or some other build?
…On Sun, May 8, 2022, 9:29 PM GiovanH ***@***.***> wrote:
So what specific version/tag of jellyfin does this target? I don't see
anything in the readme requirements
—
Reply to this email directly, view it on GitHub
<#47 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALYWLWUQEWBB44WI6MNFTDVJCID7ANCNFSM5UYYLJNA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
I have youtube videos arranged by channel, with the IDs in square brackets and accompanying info.json files:
But when jellyfin runs, the youtube provider gives every video in the folder the same metadata, even though the info.json files are correct:
I haven't been able to find much in the way of logs to debug this, so any pointers would be greatly appreciated.
The text was updated successfully, but these errors were encountered: