Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match flag colors with Anki Desktop #18018

Open
BrayanDSO opened this issue Feb 24, 2025 · 10 comments · May be fixed by #18052
Open

Match flag colors with Anki Desktop #18018

BrayanDSO opened this issue Feb 24, 2025 · 10 comments · May be fixed by #18052

Comments

@BrayanDSO
Copy link
Member

Both light and dark flags.

The task is to use the same colors for flags that Anki desktop uses.

The colors are going to be relevant when the new reviewer shows the flags with the JavaScript methods from upstream.

@devyk100
Copy link

May I take this up?

@harikrishna-au
Copy link

@BrayanDSO will you assign us the issue, or else we can directly raise a pr after completion?

@anushkajiyaa
Copy link

@BrianDSO I would like to work on this issue

@rishabh-jain89
Copy link

Hey @BrayanDSO Can i look into this issue?I would like to work on it.

@coderang-gk
Copy link

hey @BrayanDSO can i work on this?

@BrayanDSO
Copy link
Member Author

@devyk100 asked first, so they can go

@david-allison
Copy link
Member

david-allison commented Mar 24, 2025

when the new reviewer shows the flags with the JavaScript methods

Are we definitely doing this rather than using the app bar? The 'mark' icon is ugly, and the flags feel better-placed in the current reviewer. [for both placements]

Given the screenshots in the PR, I prefer our existing colors (and believe they were added specifically to move away from the Desktop color scheme):

@BrayanDSO
Copy link
Member Author

BrayanDSO commented Mar 24, 2025

The 'mark' icon is ugly, and the flags feel better-placed in the current reviewer. [for both placements]

The icons will be the same used in AnkiDroid, no the ones used in Anki (Anki icons depends on the device fonts, so they are not safe to use anyway)

About the placement, what do you propose? mini icons in the top-center (or bottom) of the screen? Adding a minibar would consume screen space and I'd like to avoid that if it's just for flags/marks. Their place was a painpoint when designing the screen, so I went with the easiest option.

About the colors, I'm indifferent. Using AnkiDroid's colors is simple. I just went with the consistency path, but I'm completely fine with using the current ones, just need a decision.

p.s.: idk where to put the timer. I'm just ignoring its existence for now

@david-allison
Copy link
Member

david-allison commented Mar 24, 2025

Colors are a mild preference, and if you'd prefer consistency and it's a conscious choice, then I'll defer to you. The design of the screen is a series of great design decisions.


Off-topic for this issue

Flag placement: I'll sleep on this one. I suspect we need to bring the bar back, given the quantity of possible items which should be visible & non-intrusive (flag/mark/timer)

For the flag in particular, we might be able to get away with something subtle (colored underlines/shadow changes), but that wouldn't fix the timer issue, so may not be worth looking into, unless it's an idea someone loves

@BrayanDSO
Copy link
Member Author

for tablets, which are commonly used in landscape mode, I don't want a horizontal minibar consuming space. The timer could be in the bottom bar since there's plenty of space there, and the flag mark could be in the corners like the desktop version.

for phones, the minibar is probably the best idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants