fix: fix uncaught error in proposal time remaining (#998)

anoma · Aug 19, 2024 · 7cf5d7f · 7cf5d7f
1 parent 28c60f3
commit 7cf5d7f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/apps/namadillo/src/App/Governance/ProposalHeader.tsx b/apps/namadillo/src/App/Governance/ProposalHeader.tsx
@@ -234,7 +234,7 @@ const TimeRemaining: React.FC<{
           proposal.currentTime,
           proposal.endTime
         );
-        return `${timeRemaining} Remaining`;
+        return timeRemaining ? `${timeRemaining} Remaining` : "";
       }
     }
 

diff --git a/apps/namadillo/src/utils/index.ts b/apps/namadillo/src/utils/index.ts
@@ -60,11 +60,10 @@ export const secondsToDateTimeString = (seconds: bigint): string =>
 export const secondsToTimeRemainingString = (
   startTimeInSeconds: bigint,
   endTimeInSeconds: bigint
-): string => {
+): string | undefined => {
+  return;
   if (endTimeInSeconds < startTimeInSeconds) {
-    throw new Error(
-      `endTimeInSeconds ${endTimeInSeconds} is before startTimeInSeconds ${startTimeInSeconds}`
-    );
+    return undefined;
   }
 
   const toMilliNumber = (n: bigint): number =>