From 7cf5d7ff164361b66b1b1b80c0d718ce0df81aa9 Mon Sep 17 00:00:00 2001 From: Eric Corson Date: Wed, 14 Aug 2024 10:38:31 +0900 Subject: [PATCH] fix: fix uncaught error in proposal time remaining (#998) --- apps/namadillo/src/App/Governance/ProposalHeader.tsx | 2 +- apps/namadillo/src/utils/index.ts | 7 +++---- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/apps/namadillo/src/App/Governance/ProposalHeader.tsx b/apps/namadillo/src/App/Governance/ProposalHeader.tsx index da3b232a69..314ae66e4a 100644 --- a/apps/namadillo/src/App/Governance/ProposalHeader.tsx +++ b/apps/namadillo/src/App/Governance/ProposalHeader.tsx @@ -234,7 +234,7 @@ const TimeRemaining: React.FC<{ proposal.currentTime, proposal.endTime ); - return `${timeRemaining} Remaining`; + return timeRemaining ? `${timeRemaining} Remaining` : ""; } } diff --git a/apps/namadillo/src/utils/index.ts b/apps/namadillo/src/utils/index.ts index ab4b4f8741..b24619f440 100644 --- a/apps/namadillo/src/utils/index.ts +++ b/apps/namadillo/src/utils/index.ts @@ -60,11 +60,10 @@ export const secondsToDateTimeString = (seconds: bigint): string => export const secondsToTimeRemainingString = ( startTimeInSeconds: bigint, endTimeInSeconds: bigint -): string => { +): string | undefined => { + return; if (endTimeInSeconds < startTimeInSeconds) { - throw new Error( - `endTimeInSeconds ${endTimeInSeconds} is before startTimeInSeconds ${startTimeInSeconds}` - ); + return undefined; } const toMilliNumber = (n: bigint): number =>