You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Seis.jl has always used getproperty (.-access) to get at and set nested properties of things like Array{<:Trace}s. This worked fine when (pre Julia v1.11) Array was implemented in C and the type didn't have Julia fields to access. Nonetheless, this has always been type piracy, and now this will cause invalidations.
In a future major breaking version of Seis.jl, we should stop committing type piracy and probably instead only enable .-access for new container array types which we own. This will require implementing the full AbtractArray and broadcasting interfaces on a type like:
Seis.jl has always used
getproperty
(.
-access) to get at and set nested properties of things likeArray{<:Trace}
s. This worked fine when (pre Julia v1.11)Array
was implemented in C and the type didn't have Julia fields to access. Nonetheless, this has always been type piracy, and now this will cause invalidations.In a future major breaking version of Seis.jl, we should stop committing type piracy and probably instead only enable
.
-access for new container array types which we own. This will require implementing the fullAbtractArray
and broadcasting interfaces on a type like:The text was updated successfully, but these errors were encountered: