Change order of deletion for speed and duplex issue #868 #869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bl1nkbl1nk Can you please add unit tests and a changelog that justifies your change |
Under which release should I put the change log notes. Also can you provide some information on how to do the unit test? Is my first time to actually do a PR for this. |
|
@bl1nkbl1nk To add a changelog you can just add a new file in changelogs/fragments and add the changelog under the correct attribute. ref - PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This is to fix #868
ISSUE TYPE
COMPONENT NAME
nxos interfaces
ADDITIONAL INFORMATION
This just changes the order of operation for the speed and duplex when deleting them. Doing it that way doesn't cause the error that was described in bug 868