Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable-1] Add OC, hashi_vault and Google removal announcements #1560

Merged
merged 3 commits into from
Jan 4, 2021
Merged

[stable-1] Add OC, hashi_vault and Google removal announcements #1560

merged 3 commits into from
Jan 4, 2021

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

See ansible-collections/overview#128.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

changelog

@felixfontein felixfontein mentioned this pull request Dec 29, 2020
Closed
@felixfontein
Copy link
Collaborator Author

recheck

2 similar comments
@felixfontein
Copy link
Collaborator Author

recheck

@felixfontein
Copy link
Collaborator Author

recheck

Andersson007
Andersson007 approved these changes Dec 30, 2020
View reviewed changes
Copy link
Contributor

@Andersson007 Andersson007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but i.e. -> in other words, IMO, it would be better:)

@felixfontein
Copy link
Collaborator Author

I replaced i.e. with in other words for the oc fragment (since there is exactly one plugin and thus one FQCN), and with for example for the google fragment (since there it is an example).

@felixfontein felixfontein changed the title [stable-1] Add OC and Google removal announcements [stable-1] Add OC, hashi_vault and Google removal announcements Jan 4, 2021
@felixfontein
Copy link
Collaborator Author

felixfontein commented Jan 4, 2021 •
edited
Loading

This should only be merged once ansible-community/ansible-build-data#47 has been merged. Has been done.

@felixfontein felixfontein merged commit de85c11 into ansible-collections:stable-1 Jan 4, 2021
@felixfontein felixfontein deleted the removal-announcements branch January 4, 2021 10:06
@felixfontein
Copy link
Collaborator Author

@Andersson007 @gundalow thanks for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andersson007 Andersson007 Andersson007 approved these changes

@gundalow gundalow gundalow approved these changes

@dericcrago dericcrago Awaiting requested review from dericcrago

@dmsimard dmsimard Awaiting requested review from dmsimard

Assignees
No one assigned
Labels
community_review docs has_issue needs_triage owner_pr PR created by owner/maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@felixfontein @gundalow @Andersson007 @ansibullbot