-
Notifications
You must be signed in to change notification settings - Fork 49
Remove officially unmaintained collections #214
Remove officially unmaintained collections #214
Conversation
I marked this as WIP since this needs to be voted on before it can be merged. |
I've added ansible-community/community-topics#130. Maybe we can discuss this tomorrow and, if people agree, I'll start a vote. |
c00129f
to
8b5bf64
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mariolenz thanks for leasing the effort!
Also it reminds me that we should move the docs from here to docs.ansible.com one day to somewhere close to collection inclusion requirements i think. Just a general though
Co-authored-by: Andrew Klychkov <[email protected]>
@felixfontein @flowerysong I'm referring to the general processes again. What do you think about this PR now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@samccann What do you think about my last commit / this PR now? |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really just a number agreement/grammar nit, though I also tried to make the first heading's structure more like other headings at this level.
removal_from_ansible.rst
Outdated
@@ -119,8 +119,22 @@ Process | |||
Unmaintained collections | |||
======================== | |||
|
|||
Identifying and removing an unmaintained collection | |||
--------------------------------------------------- | |||
Collections that have been announced deprecated / unmaintained by their maintainers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Collections that have been announced deprecated / unmaintained by their maintainers | |
Removing a collection that has been explicitly deprecated or abandoned by its former maintainers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like "former maintainers" here. When they deprecate or abandon the collection, they are still the maintainers. They are only former maintainers afterwards.
What I mean is: Only current maintainers can deprecate or abandon a collection. What do you think about my last commit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not a big deal either way, but when this process is taking place they are the former maintainers so it feels weird to call them the maintainers. The collection currently has no maintainers, or else it would not be eligible for this process.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Andersson007 @briantist @felixfontein @russoz @samccann What do you think, "former maintainers" or just "maintainers"? Personally, I don't like the "former" but I'm open to both.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deprecated collections can still be maintained. Only when they are unmaintained or abandoned (is there actually a difference between the two?) they no longer have maintainers. So depending on context, both can be the right wording. So how about writing (former) maintainers
?
cfeb641
to
1fb5329
Compare
1fb5329
to
81c1150
Compare
The vote on merging this has been accepted. |
SUMMARY
The current process to identify and remove an unmaintained collection looks very much focused on abandoned collections. But I think we should have a way to remove a collection that announces itself as being unmaintained quicker.
ISSUE TYPE
COMPONENT NAME
removal_from_ansible.rst
ADDITIONAL INFORMATION
ansible-community/community-topics#124
cc @felixfontein