Skip to content
This repository has been archived by the owner on May 28, 2024. It is now read-only.

Remove officially unmaintained collections #214

Merged

Conversation

mariolenz
Copy link
Contributor

SUMMARY

The current process to identify and remove an unmaintained collection looks very much focused on abandoned collections. But I think we should have a way to remove a collection that announces itself as being unmaintained quicker.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

removal_from_ansible.rst

ADDITIONAL INFORMATION

ansible-community/community-topics#124

cc @felixfontein

@felixfontein felixfontein changed the title Remoce officially unmaintained collections [WIP] Remoce officially unmaintained collections Aug 14, 2022
@felixfontein
Copy link
Contributor

I marked this as WIP since this needs to be voted on before it can be merged.

@felixfontein felixfontein changed the title [WIP] Remoce officially unmaintained collections [WIP] Remove officially unmaintained collections Aug 15, 2022
@mariolenz mariolenz changed the title [WIP] Remove officially unmaintained collections Remove officially unmaintained collections Aug 22, 2022
@mariolenz mariolenz changed the title Remove officially unmaintained collections [WIP] Remove officially unmaintained collections Aug 22, 2022
@mariolenz
Copy link
Contributor Author

I marked this as WIP since this needs to be voted on before it can be merged.

I've added ansible-community/community-topics#130. Maybe we can discuss this tomorrow and, if people agree, I'll start a vote.

@mariolenz mariolenz force-pushed the remove_deprecated_collections branch from c00129f to 8b5bf64 Compare March 5, 2024 17:40
Copy link
Contributor

@Andersson007 Andersson007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mariolenz thanks for leasing the effort!

Also it reminds me that we should move the docs from here to docs.ansible.com one day to somewhere close to collection inclusion requirements i think. Just a general though

removal_from_ansible.rst Outdated Show resolved Hide resolved
@mariolenz
Copy link
Contributor Author

@felixfontein @flowerysong I'm referring to the general processes again. What do you think about this PR now?

Copy link
Contributor

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me!

Copy link
Contributor

@russoz russoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

removal_from_ansible.rst Outdated Show resolved Hide resolved
@mariolenz
Copy link
Contributor Author

@samccann What do you think about my last commit / this PR now?

@mariolenz mariolenz requested a review from samccann March 12, 2024 15:40
@samccann
Copy link
Contributor

LGTM

Copy link

@flowerysong flowerysong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really just a number agreement/grammar nit, though I also tried to make the first heading's structure more like other headings at this level.

@@ -119,8 +119,22 @@ Process
Unmaintained collections
========================

Identifying and removing an unmaintained collection
---------------------------------------------------
Collections that have been announced deprecated / unmaintained by their maintainers

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Collections that have been announced deprecated / unmaintained by their maintainers
Removing a collection that has been explicitly deprecated or abandoned by its former maintainers

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like "former maintainers" here. When they deprecate or abandon the collection, they are still the maintainers. They are only former maintainers afterwards.

What I mean is: Only current maintainers can deprecate or abandon a collection. What do you think about my last commit?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a big deal either way, but when this process is taking place they are the former maintainers so it feels weird to call them the maintainers. The collection currently has no maintainers, or else it would not be eligible for this process.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Andersson007 @briantist @felixfontein @russoz @samccann What do you think, "former maintainers" or just "maintainers"? Personally, I don't like the "former" but I'm open to both.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecated collections can still be maintained. Only when they are unmaintained or abandoned (is there actually a difference between the two?) they no longer have maintainers. So depending on context, both can be the right wording. So how about writing (former) maintainers?

removal_from_ansible.rst Outdated Show resolved Hide resolved
@mariolenz mariolenz force-pushed the remove_deprecated_collections branch from cfeb641 to 1fb5329 Compare March 12, 2024 18:48
@mariolenz mariolenz force-pushed the remove_deprecated_collections branch from 1fb5329 to 81c1150 Compare March 12, 2024 18:55
@mariolenz mariolenz requested a review from flowerysong March 12, 2024 19:04
@mariolenz mariolenz changed the title [WIP] Remove officially unmaintained collections Remove officially unmaintained collections Mar 23, 2024
@mariolenz
Copy link
Contributor Author

The vote on merging this has been accepted.

@mariolenz mariolenz merged commit 64ef388 into ansible-collections:main Mar 23, 2024
1 check passed
@mariolenz mariolenz deleted the remove_deprecated_collections branch March 23, 2024 13:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants