Skip to content
This repository has been archived by the owner on May 28, 2024. It is now read-only.

Remove officially unmaintained collections #214

Merged
merged 8 commits into from
Mar 23, 2024
Merged

Remove officially unmaintained collections #214

Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4526fc3
Remoce officially unmaintained collections
mariolenz Aug 14, 2022
e0b56bc
Update PR
mariolenz Mar 4, 2024
9a582d7
Simplify process
mariolenz Mar 4, 2024
8b5bf64
Refer to announcing upcoming removal and removal again
mariolenz Mar 5, 2024
4647232
Commit improvement from Andersson007
mariolenz Mar 8, 2024
079739f
Do not remove after feature freeze
mariolenz Mar 12, 2024
81c1150
Improvements from flowerysong
mariolenz Mar 12, 2024
d39757d
Update: (former) maintainers
mariolenz Mar 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions removal_from_ansible.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ Announcing upcoming removal

#. Announce upcoming removal in the Ansible changelog (``https://github.com/ansible-community/ansible-build-data/blob/main/<X>/changelog.yaml``).
See the following link for an `example on how to add changelog entries to the Ansible changelog <https://github.com/ansible-community/ansible-build-data/pull/68/files>`__.
#. Announce upcoming removal in the collection's issue tracker.
#. Announce upcoming removal in the collection's issue tracker if possible.
#. Announce upcoming removal in The Bullhorn.

.. _remove_collection:
Expand Down Expand Up @@ -119,8 +119,19 @@ Process
Unmaintained collections
========================

Identifying and removing an unmaintained collection
---------------------------------------------------
Collections that have been announced deprecated / unmaintained by their maintainers
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Collections that have been announced deprecated / unmaintained by their maintainers
Removing a collection that has been explicitly deprecated or abandoned by its former maintainers

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like "former maintainers" here. When they deprecate or abandon the collection, they are still the maintainers. They are only former maintainers afterwards.

What I mean is: Only current maintainers can deprecate or abandon a collection. What do you think about my last commit?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a big deal either way, but when this process is taking place they are the former maintainers so it feels weird to call them the maintainers. The collection currently has no maintainers, or else it would not be eligible for this process.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Andersson007 @briantist @felixfontein @russoz @samccann What do you think, "former maintainers" or just "maintainers"? Personally, I don't like the "former" but I'm open to both.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecated collections can still be maintained. Only when they are unmaintained or abandoned (is there actually a difference between the two?) they no longer have maintainers. So depending on context, both can be the right wording. So how about writing (former) maintainers?

-----------------------------------------------------------------------------------

Process
~~~~~~~

#. `Announce upcoming removal from the next major Ansible release <announce_removal_>`_.
#. `Remove collection from the next major Ansible release <remove_collection_>`_.
mariolenz marked this conversation as resolved.
Show resolved Hide resolved

See `<https://github.com/ansible-community/ansible-build-data/pull/374/files>`__ for an example on how to this in just one PR in ``ansible-build-data``.
mariolenz marked this conversation as resolved.
Show resolved Hide resolved

Identifying and removing an unmaintained collection that has not been deprecated by their maintainers
mariolenz marked this conversation as resolved.
Show resolved Hide resolved
-----------------------------------------------------------------------------------------------------

Conditions for removal
~~~~~~~~~~~~~~~~~~~~~~
Expand Down
Loading