Skip to content
This repository has been archived by the owner on May 14, 2024. It is now read-only.

[associated vote ended on 2022-12-08] Unmaintained collection: cisco.nso #155

Closed
mariolenz opened this issue Oct 26, 2022 · 12 comments
Closed

Comments

@mariolenz
Copy link
Contributor

mariolenz commented Oct 26, 2022

Summary

The cisco.nso collection looks unmaintained / abandoned, it has:

@Andersson007
Copy link
Contributor

@mariolenz thanks for creating the issue!
I think no new commits and no releases are themselves not indicators of absence of maintenance if there are no open issues/PRs not reviewed/merged, etc.
IMO we should highlight that the violation, in this particular case, is not running CI and those things spotted by @felixfontein in CiscoDevNet/ansible-nso#4. So the maintainers have to fix them to avoid exclusion.
What do you think?

@mariolenz
Copy link
Contributor Author

@Andersson007

I think no new commits and no releases are themselves not indicators of absence of maintenance if there are no open issues/PRs not reviewed/merged, etc.

I'm not sure if I agree. English isn't my first language, so maybe I'm putting this badly but I should say that no new commits and releases are indicators of absence of maintenance. Just indicators. Not strong ones and all by themselves not sufficient. Because, as you say, there may be simply no need because nobody opened any issues or PRs.

IMO we should highlight that the violation, in this particular case, is not running CI and those things spotted by @felixfontein in CiscoDevNet/ansible-nso#4. So the maintainers have to fix them to avoid exclusion. What do you think?

Well, if the collection ist still maintained the maintainers hopefully follow the link to this discussion and see that we consider those the main points. If it's not maintained any more, it wouldn't help to point this out in the issue, would it?

FYI, there's also CiscoDevNet/ansible-nso#11 since today.

@Andersson007
Copy link
Contributor

@mariolenz

I should say that no new commits and releases are indicators of absence of maintenance. Just indicators. Not strong ones and all by themselves not sufficient.

Yep, i agree, thanks for clarifying

Well, if the collection ist still maintained the maintainers hopefully follow the link to this discussion and see that we consider those the main points. If it's not maintained any more, it wouldn't help to point this out in the issue, would it?

Yep, you're right, if they appear we could take a closer look at the collection and elaborate more on stuff to fix. To create a full list of must-fix things would be maybe a waste of energy at this point.

Thanks

@gotmax23
Copy link
Contributor

gotmax23 commented Nov 23, 2022

I'm +1 to considering this collection unmaintained and moving forward with the removal process. The collection has no recent activity, as @mariolenz said, and they've ignored reports of collection requirements violations.

@mariolenz
Copy link
Contributor Author

@Andersson007 @felixfontein What do you think, is it time yet to start a vote and announce it in Bullhorn yet? The issue in the collection’s issue tracker was created 2022-10-26 and was announced in Bullhorn 2022-10-28.

I could open a vote today and let it end next week Thursday. This way, we could get it into this week's Bullhorn issue and the result into the next one.

Or should we wait another week?

@felixfontein
Copy link
Contributor

I think it's ok to wait one more week. (The US is pretty busy with thanksgiving anyway.)

@mariolenz
Copy link
Contributor Author

The US is pretty busy with thanksgiving anyway.

Good point. Then let's wait another week befor moving forward with the removal process.

@mariolenz
Copy link
Contributor Author

Vote is happening in #165

@mariolenz mariolenz changed the title Unmaintained collection: cisco.nso [Vote ends on 2022-12-08] Unmaintained collection: cisco.nso Nov 30, 2022
@mariolenz
Copy link
Contributor Author

I counted votes: 7 x +1 from SC (mariolenz Andersson007 felixfontein markuman gotmax23 russoz gundalow)

@Andersson007
Copy link
Contributor

I counted votes: 7 x +1 from SC (mariolenz Andersson007 felixfontein markuman gotmax23 russoz gundalow)

I counted the same number. The quorum has been reached.

@mariolenz mariolenz changed the title [Vote ends on 2022-12-08] Unmaintained collection: cisco.nso [Vote ended on 2022-12-08] Unmaintained collection: cisco.nso Dec 8, 2022
@mariolenz
Copy link
Contributor Author

In that case the proposal has been accepted and we will announce to remove the collection from Ansible 9.

Thanks all!

@gotmax23
Copy link
Contributor

gotmax23 commented Dec 8, 2022

Closing in favor of ansible-community/ansible-build-data#190.

@gotmax23 gotmax23 closed this as completed Dec 8, 2022
@felixfontein felixfontein changed the title [Vote ended on 2022-12-08] Unmaintained collection: cisco.nso [associated vote ended on 2022-12-08] Unmaintained collection: cisco.nso Mar 29, 2023
gotmax23 added a commit to gotmax23/ansible-build-data that referenced this issue May 21, 2023
gotmax23 added a commit to gotmax23/ansible-build-data that referenced this issue May 21, 2023
gotmax23 added a commit to gotmax23/ansible-build-data that referenced this issue May 21, 2023
gotmax23 added a commit to gotmax23/ansible-build-data that referenced this issue May 21, 2023
gotmax23 added a commit to gotmax23/ansible-build-data that referenced this issue May 22, 2023
gotmax23 added a commit to gotmax23/ansible-build-data that referenced this issue Jun 2, 2023
gotmax23 added a commit to gotmax23/ansible-build-data that referenced this issue Jun 2, 2023
gotmax23 added a commit to gotmax23/ansible-build-data that referenced this issue Jun 2, 2023
gotmax23 added a commit to ansible-community/ansible-build-data that referenced this issue Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants