Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port integration with Promotheus from amq collection #11

Closed
rpelisse opened this issue Mar 27, 2023 · 7 comments
Closed

Port integration with Promotheus from amq collection #11

rpelisse opened this issue Mar 27, 2023 · 7 comments
Assignees
Labels
pr_submitted A label to tag issue having already a fix (to ease sorting out issues)

Comments

@rpelisse
Copy link
Collaborator

SUMMARY

The amq collection has support for Promotheus that could be easily (hopefully) ported into this one.

ISSUE TYPE
  • Feature Idea
@RanabirChakraborty
Copy link
Member

@rpelisse can I work on it?

@rpelisse
Copy link
Collaborator Author

@RanabirChakraborty Please do!

@rpelisse
Copy link
Collaborator Author

@RanabirChakraborty Are you anywhere on this topic? if you need any help, maybe ask Guido or @rmarting?

@rmarting
Copy link
Collaborator

rmarting commented Jul 12, 2023

AFAIK Prometheus export agent is not included in AMQ Streams for RHEL. The monitoring can be done using JMX ports as another JVM process. The documentation describing that is here: https://access.redhat.com/documentation/en-us/red_hat_amq_streams/2.4/html/using_amq_streams_on_rhel/monitoring-str#con-jmx-configuration-options-str

Kafka Exporter is the component that exposes some metrics for Prometheus, so we can review it and add as a deployment option. Info: https://access.redhat.com/documentation/en-us/red_hat_amq_streams/2.4/html-single/using_amq_streams_on_rhel/index#assembly-kafka-exporter-str

@rpelisse
Copy link
Collaborator Author

@rmarting Given your feedback and the use of JMX instead of Promotheus, I wonder if we should not simply close this. If someone wants to provide integration with Promotheus, we'll be happy to merge it, but I don't think it should be on our priority list. WDYT?

@rmarting
Copy link
Collaborator

I agree @rpelisse ! The latest commits allow to declare the JMX properties so they will allow to monitor and get the metrics from Kafka components. As there is no an official way to implement the Prometheus integration, we can close this issue. In the future, a new one can track better that integration.

Go ahead and close it!

@rpelisse rpelisse reopened this Oct 4, 2023
@rpelisse rpelisse self-assigned this Oct 4, 2023
@rpelisse
Copy link
Collaborator Author

rpelisse commented Oct 4, 2023

Fixed by #93

@rpelisse rpelisse added the pr_submitted A label to tag issue having already a fix (to ease sorting out issues) label Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr_submitted A label to tag issue having already a fix (to ease sorting out issues)
Projects
None yet
Development

No branches or pull requests

3 participants