feat: support receiving file contents and env vars from EDA Server #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkanoor
force-pushed
the
file_contents
branch
2 times, most recently
from
fa11623 to
c90f1d3
Compare
There was a problem hiding this comment.
Questions:
- Should the CHANGELOG be updated?
- Does make sense to support
non_fq_key? I feel it would be simpler iffilenameisfilenamesand it is always a dict with N nested keys.
Concerns:
I'm concerned about the amount of assumptions that we make from the server side that would end up in unhandled exceptions:
template_keycan be None,data.get("data")can be None- what if
len(keys) == 1 and template_key != "template"?
Alex-Izquierdo
previously approved these changes
Sep 2, 2024
mkanoor
force-pushed
the
file_contents
branch
from
071d2ad to
bf725ab
Compare
mkanoor
force-pushed
the
file_contents
branch
from
bf725ab to
87a0834
Compare
|
jshimkus-rh
reviewed
Nov 11, 2024
mkanoor
force-pushed
the
file_contents
branch
3 times, most recently
from
ee204e7 to
540f785
Compare
mkanoor
changed the title
mkanoor
changed the title
mkanoor
force-pushed
the
file_contents
branch
from
540f785 to
c897999
Compare
bzwei
reviewed
Nov 20, 2024
AAP Credential Types support File contents via file injectors. https://docs.ansible.com/automation-controller/latest/html/userguide/credential_types.html We create temporary files with the data sent from Server The source plugin can access the temporary file names to access the data. Supports single file as well as multiple files. To access the filenames in the source rulebook you can use the following extra vars - eda.filename or - eda.filename.<<key_name1>> - eda.filename.<<key_name2>> e.g. ``` - name: Use payload file to check events hosts: all sources: - ansible.eda.generic: payload_file: "{{ eda.filename.test_payload_file }}" ``` The env vars are treated like extra_vars and inserted into the current processes env
mkanoor
force-pushed
the
file_contents
branch
from
c897999 to
3586680
Compare
zkayyali812
approved these changes
Nov 20, 2024
bzwei
reviewed
Nov 20, 2024
hsong-rh
approved these changes
Nov 21, 2024
bzwei
approved these changes
Nov 21, 2024
Alex-Izquierdo
approved these changes
Nov 22, 2024
|
zkayyali812
pushed a commit
that referenced
this pull request
Dec 9, 2024
) AAP Credential Types support File contents via file injectors. https://docs.ansible.com/automation-controller/latest/html/userguide/credential_types.html We create temporary files with the data sent from Server The source plugin can access the temporary file names to access the data. Supports single file as well as multiple files. To access the filenames in the source rulebook you can use the following extra vars - eda.filename or - eda.filename.<<key_name1>> - eda.filename.<<key_name2>> e.g. ``` - name: Use payload file to check events hosts: all sources: - ansible.eda.generic: payload_file: "{{ eda.filename.test_payload_file }}" ``` The env variables are treated like extra_vars and added to the current processes environment https://issues.redhat.com/browse/AAP-25519
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AAP Credential Types support File contents via file injectors.
https://docs.ansible.com/automation-controller/latest/html/userguide/credential_types.html
We create temporary files with the data sent from Server The source plugin can access the temporary file names to access the data.
Supports single file as well as multiple files.
To access the filenames in the source rulebook you can use the following extra vars
e.g.
The env variables are treated like extra_vars and added to the current processes environment
https://issues.redhat.com/browse/AAP-25519