Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Component] Alert 번역 #28

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

[Component] Alert 번역 #28

wants to merge 9 commits into from

Conversation

Banal972
Copy link
Collaborator

Todo

  • 컴포넌트의 Alert를 번역하였습니다.
  • 기존 영문에서는 Tab부분이 번역이 되어있지 않아 Tab부분도 번역 하였습니다.
  • Demo의 내용은 영문 그대로 두는게 좋을것 같아서 번역하지 않았습니다.

@Banal972 Banal972 self-assigned this Oct 11, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 11, 2024 •
edited
Loading

Preview failed

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 11, 2024 •
edited
Loading

Visual Regression Build for PR #28 Failed ❌

Potential causes:

owjs3901
owjs3901 reviewed Oct 21, 2024
View reviewed changes
components/alert/design/demo/action.tsx
</Typography.Paragraph>
<Typography.Link onClick={() => setExpandA((prev) => !prev)}>
{expandA ? '收起' : '展开更多'}
{expandA ? '접기' : '확장'}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

접기/펼치기 혹은 축소/확장 은 어떻게 생각하실까요?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

한자 명사끼리 사용하는 식으로 일관성을 유지해야 하지 않을까 하여 코멘트 달아요

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owjs3901 owjs3901 owjs3901 approved these changes

Assignees

@Banal972 Banal972

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Banal972 @owjs3901