Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readme.md says the default time window is 4, but it seems to actually be 1 #203

Closed
LiamBennettStream opened this issue Jun 5, 2024 · 2 comments
Closed

Readme.md says the default time window is 4, but it seems to actually be 1 #203

LiamBennettStream opened this issue Jun 5, 2024 · 2 comments

Comments

@LiamBennettStream
Copy link

Under the 'Validation window' section it says the default is 4 but the source has protected $window = 1;

Not sure which is correct
@LiamBennettStream
Copy link
Author

Noticed there is actually a pull request for this already

@spaze
Copy link
Contributor

spaze commented Oct 13, 2024

For cross ref the PR is #195

@spaze spaze mentioned this issue Oct 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@spaze @antonioribeiro @LiamBennettStream