fix(types): update / fix types declaration file #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@geopic there are conflicts here, please fix them if you want the PR to be accepted. |
|
I'll get down to it soon @antonreshetov 👌 |
|
Sorted @antonreshetov |
|
@geopic The src folders are deleted before bundling, so won't this fail for anyone who npm installs? |
|
@geopic could this pr still be fixed and merged? And could it be used for Vue3? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #14, #21. Let me know if there are any issues.
Thank you for your contribution to the vue-unicons repo.
Before submitting this PR, please make sure:
What kind of change does this PR introduce? (check at least one)
Importantly
To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on PR.