fix: fix error occurred when setRenderer (#1861)

* fix: fix error occured when setRenderer * chore: commit changeset
antvis · Nov 27, 2024 · 840bf90 · 840bf90
1 parent d4752e2
commit 840bf90
Show file tree

Hide file tree

Showing 6 changed files with 20 additions and 4 deletions.
diff --git a/.changeset/tidy-bulldogs-give.md b/.changeset/tidy-bulldogs-give.md
@@ -0,0 +1,5 @@
+---
+'@antv/g-lite': patch
+---
+
+fix: fix error occured when setRenderer
diff --git a/__tests__/demos/bugfix/index.ts b/__tests__/demos/bugfix/index.ts
@@ -10,3 +10,4 @@ export { test_pick } from './1747';
 export { issue_1760 } from './1760';
 export { textWordWrap } from './textWordWrap';
 export { group_with_stroke } from './group-with-stroke';
+export { switchRenderer } from './switch-renderer';
diff --git a/__tests__/demos/bugfix/switch-renderer.ts b/__tests__/demos/bugfix/switch-renderer.ts
@@ -0,0 +1,13 @@
+import { Renderer } from '@antv/g-canvas';
+
+export async function switchRenderer(context) {
+  const { canvas } = context;
+
+  await canvas.ready;
+
+  const renderer = new Renderer();
+
+  canvas.setRenderer(renderer);
+
+  console.log('switched');
+}
diff --git a/__tests__/main.ts b/__tests__/main.ts
@@ -155,7 +155,7 @@ plot();
 async function plot() {
   if (currentContainer) {
     currentContainer.remove();
-    if (canvas) canvas.destroy(false);
+    if (canvas) canvas.destroy();
     if (prevAfter) prevAfter();
   }
   currentContainer = document.createElement('div');

diff --git a/__tests__/unit/abstract-renderer.spec.ts b/__tests__/unit/abstract-renderer.spec.ts
@@ -22,7 +22,6 @@ describe('Abstract renderer', () => {
       enableRenderingOptimization: false,
       enableDirtyRectangleRendering: true,
       enableDirtyRectangleRenderingDebug: false,
-      enableRenderingOptimization: false,
       enableSizeAttenuation: true,
     });
 

diff --git a/packages/g-lite/src/Canvas.ts b/packages/g-lite/src/Canvas.ts
@@ -423,8 +423,6 @@ export class Canvas extends EventTarget implements ICanvas {
     if (this.context.rBushRoot) {
       // clear rbush
       this.context.rBushRoot.clear();
-      this.context.rBushRoot = null;
-      this.context.renderingContext.root = null;
     }
 
     if (!skipTriggerEvent) {