Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wip]chore: update pointLayer billboard draw engine #2135

Merged
merged 2 commits into from
Dec 11, 2023
Merged

[wip]chore: update pointLayer billboard draw engine #2135

merged 2 commits into from
Dec 11, 2023

Conversation

zhnny
Copy link
Contributor

@zhnny zhnny commented Dec 7, 2023

re #2093

[English Template / 英文模板]

🤔 这个变动的性质是？

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 工作流程
  • 版本更新
  • 其他改动（是关于什么的改动？）

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

语言 更新描述
🇺🇸 英文
🇨🇳 中文

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

lzxue
lzxue reviewed Dec 7, 2023
View reviewed changes
Copy link
Contributor

@lzxue lzxue left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

 inject: this.getInject(),

v_color = vec4(a_Color.xyz, a_Color.w * u_opacity);

改成

v_color = vec4(a_Color.xyz, a_Color.w * opacity);

packages/layers/src/point/models/billboard_point.ts Outdated
u_stroke_opacity: strokeOpacity,
u_stroke_width: strokeWidth,
u_stroke_color: rgb2arr(stroke),
};
u_opacity: opacity
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

删除 u_pactiy

lzxue
lzxue reviewed Dec 7, 2023
View reviewed changes
packages/layers/src/point/shaders/billboard_point_vert.glsl Outdated
float u_additive;
float u_stroke_opacity;
float u_stroke_width;
float u_opacity;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

删除

@lzxue lzxue changed the title chore: update pointLayer billboard draw engine [wup]chore: update pointLayer billboard draw engine Dec 8, 2023
@github-actions github-actions bot removed the pr(chore) label Dec 8, 2023
@lzxue lzxue changed the title [wup]chore: update pointLayer billboard draw engine [wip]chore: update pointLayer billboard draw engine Dec 8, 2023
@lzxue lzxue linked an issue Dec 8, 2023 that may be closed by this pull request
L7 3.0 引擎升级-点图层-多人认领 #2093
Closed
11 tasks
@lzxue lzxue changed the base branch from master to chore_point_layer December 11, 2023 08:12
@lzxue lzxue merged commit eaf5eff into antvis:chore_point_layer Dec 11, 2023
10 of 11 checks passed
lzxue added a commit that referenced this pull request Dec 11, 2023
@lzxue @MarkLei7 @zhnny
Chore point layer (#2152)
dda5d28 
* chore: 升级geometry的plane支持G引擎 (#2148)

Co-authored-by: Mark <[email protected]>

* chroe: 尝试升级geometry的sprite类型 (#2147)

Co-authored-by: Mark <[email protected]>

* [wip]chore: update pointLayer billboard draw engine (#2135)

* chore: update pointLayer billboard draw engine

re #2093

* chore: update pointLayer billboard draw engine

re #2093

---------

Co-authored-by: zhnny <[email protected]>

* fix: point fill animate

---------

Co-authored-by: MarkLei7 <[email protected]>
Co-authored-by: Mark <[email protected]>
Co-authored-by: zhnny <[email protected]>
Co-authored-by: zhnny <[email protected]>
@zhnny zhnny deleted the dev branch December 14, 2023 02:43
@lzxue lzxue added the AntV OSCP label Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzxue lzxue lzxue left review comments

Assignees
No one assigned
Labels
AntV OSCP ignore-for-release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

L7 3.0 引擎升级-点图层-多人认领
2 participants
@zhnny @lzxue